From: Ian Lance Taylor <ian@wasabisystems.com>
To: Bernardo Innocenti <bernie@develer.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
gdb-patches@sources.redhat.com, binutils@sources.redhat.com,
DJ Delorie <dj@redhat.com>
Subject: Re: [top-level] C++-friendly allocators for libiberty
Date: Sat, 26 Jun 2004 02:19:00 -0000 [thread overview]
Message-ID: <m31xk3m577.fsf@gossamer.airs.com> (raw)
In-Reply-To: <40DCD0EE.9010208@develer.com>
Bernardo Innocenti <bernie@develer.com> writes:
> On second thought, the interface for xrenew() or xresize() wasn't
> even usable without a size argument.
Oh yeah.
> Maybe this would be better?
>
> #define xrenewvec(P, T, N) (T *) xrealloc ((P), sizeof(T) * (N))
No, people use realloc with variable size arrays at the end of
structs. xrenewvec (or xresizevec) is a good idea, but you still need
xrenew (or xresize).
Also I noticed that you should have a space between "sizeof" and "("
in each use of "sizeof".
I prefer xresize, since that was my idea. Any other ideas?
Ian
next prev parent reply other threads:[~2004-06-26 2:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 0:50 Bernardo Innocenti
2004-06-26 1:05 ` Bernardo Innocenti
2004-06-26 1:14 ` Ian Lance Taylor
2004-06-26 1:27 ` Bernardo Innocenti
2004-06-26 2:19 ` Ian Lance Taylor [this message]
2004-06-26 2:39 ` Bernardo Innocenti
2004-06-26 2:46 ` Daniel Jacobowitz
2004-06-26 3:04 ` Bernardo Innocenti
2004-06-26 17:22 ` Andrew Cagney
2004-06-26 17:37 ` Daniel Jacobowitz
2004-06-26 17:51 ` Andrew Cagney
2004-06-27 5:36 ` Bernardo Innocenti
2004-06-28 15:43 ` Andrew Cagney
2004-06-28 18:27 ` Bernardo Innocenti
2004-06-28 18:52 ` Joseph S. Myers
2004-07-01 7:18 ` Bernardo Innocenti
2004-06-26 3:45 ` Alexandre Oliva
2004-06-26 4:18 ` Bernardo Innocenti
2004-06-26 18:31 ` Alexandre Oliva
2004-06-27 5:05 ` Bernardo Innocenti
2004-06-26 4:56 ` Zack Weinberg
2004-06-26 11:19 ` Falk Hueffner
2004-06-26 16:52 ` Bernardo Innocenti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31xk3m577.fsf@gossamer.airs.com \
--to=ian@wasabisystems.com \
--cc=bernie@develer.com \
--cc=binutils@sources.redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox