From: Falk Hueffner <hueffner@informatik.uni-tuebingen.de>
To: Zack Weinberg <zack@codesourcery.com>
Cc: Alexandre Oliva <aoliva@redhat.com>,
Bernardo Innocenti <bernie@develer.com>,
Ian Lance Taylor <ian@wasabisystems.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
gdb-patches@sources.redhat.com, binutils@sources.redhat.com,
DJ Delorie <dj@redhat.com>
Subject: Re: [top-level] C++-friendly allocators for libiberty
Date: Sat, 26 Jun 2004 11:19:00 -0000 [thread overview]
Message-ID: <87wu1uo9cy.fsf@informatik.uni-tuebingen.de> (raw)
In-Reply-To: <87wu1u7w8w.fsf@taltos.codesourcery.com> (Zack Weinberg's message of "Fri, 25 Jun 2004 21:56:31 -0700")
Zack Weinberg <zack@codesourcery.com> writes:
> Alexandre Oliva <aoliva@redhat.com> writes:
>
>>> +#define xcnewvec(T, N) (T *) xcalloc (N, sizeof (T))
>>> +#define xresize(T, P, S) (T *) xrealloc (P, S)
>>> +#define xresizevec(T, P, N) (T *) xrealloc (P, sizeof (T) * (N))
>>> +#define xobnew(O, T) (T *) obstack_alloc (O, sizeof (T))
>>
>> You're missing parentheses around N, P (twice), S and O.
>
> They're not actually necessary in this context.
How about parentheses around the whole cast? Somebody might want to
write
&xnew(T)->el
Not very likely, but IMHO it's not really worth the trouble to try to
think of every possible or sensible use instead of just adding a bunch
of parentheses.
--
Falk
next prev parent reply other threads:[~2004-06-26 11:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 0:50 Bernardo Innocenti
2004-06-26 1:05 ` Bernardo Innocenti
2004-06-26 1:14 ` Ian Lance Taylor
2004-06-26 1:27 ` Bernardo Innocenti
2004-06-26 2:19 ` Ian Lance Taylor
2004-06-26 2:39 ` Bernardo Innocenti
2004-06-26 2:46 ` Daniel Jacobowitz
2004-06-26 3:04 ` Bernardo Innocenti
2004-06-26 17:22 ` Andrew Cagney
2004-06-26 17:37 ` Daniel Jacobowitz
2004-06-26 17:51 ` Andrew Cagney
2004-06-27 5:36 ` Bernardo Innocenti
2004-06-28 15:43 ` Andrew Cagney
2004-06-28 18:27 ` Bernardo Innocenti
2004-06-28 18:52 ` Joseph S. Myers
2004-07-01 7:18 ` Bernardo Innocenti
2004-06-26 3:45 ` Alexandre Oliva
2004-06-26 4:18 ` Bernardo Innocenti
2004-06-26 18:31 ` Alexandre Oliva
2004-06-27 5:05 ` Bernardo Innocenti
2004-06-26 4:56 ` Zack Weinberg
2004-06-26 11:19 ` Falk Hueffner [this message]
2004-06-26 16:52 ` Bernardo Innocenti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wu1uo9cy.fsf@informatik.uni-tuebingen.de \
--to=hueffner@informatik.uni-tuebingen.de \
--cc=aoliva@redhat.com \
--cc=bernie@develer.com \
--cc=binutils@sources.redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ian@wasabisystems.com \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox