From: Jim Blandy <jimb@codesourcery.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA][1/5] New port: Cell BE SPU (dwarf2loc.c fix)
Date: Wed, 22 Nov 2006 01:42:00 -0000 [thread overview]
Message-ID: <m31wnwtfx2.fsf@codesourcery.com> (raw)
In-Reply-To: <200611152157.kAFLv4Ab003607@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Wed, 15 Nov 2006 22:57:04 +0100 (CET)")
"Ulrich Weigand" <uweigand@de.ibm.com> writes:
>> Would it be a good idea to introduce a new function, a companion to
>> value_from_register, that wraps up the composition of
>> value_from_register and value_as_address?
>
> You mean something like the patch below? Tested on spu, s390-ibm-linux
> and s390x-ibm-linux.
Yes, that's great. Please commit.
It seems a shame to be creating a value and then throwing it away, but
the composition of those two functions has the semantics we want, so I
don't see a good alternative without some more restructuring.
next prev parent reply other threads:[~2006-11-22 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 18:37 Ulrich Weigand
2006-11-13 19:40 ` Jim Blandy
2006-11-15 21:57 ` Ulrich Weigand
2006-11-22 1:42 ` Jim Blandy [this message]
2006-11-22 2:30 ` Daniel Jacobowitz
2006-11-22 14:10 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31wnwtfx2.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox