From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4062 invoked by alias); 22 Nov 2006 01:42:43 -0000 Received: (qmail 4053 invoked by uid 22791); 22 Nov 2006 01:42:42 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Nov 2006 01:42:37 +0000 Received: (qmail 13724 invoked from network); 22 Nov 2006 01:42:35 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Nov 2006 01:42:35 -0000 To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org Subject: Re: [RFA][1/5] New port: Cell BE SPU (dwarf2loc.c fix) References: <200611152157.kAFLv4Ab003607@d12av02.megacenter.de.ibm.com> From: Jim Blandy Date: Wed, 22 Nov 2006 01:42:00 -0000 In-Reply-To: <200611152157.kAFLv4Ab003607@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Wed, 15 Nov 2006 22:57:04 +0100 (CET)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00239.txt.bz2 "Ulrich Weigand" writes: >> Would it be a good idea to introduce a new function, a companion to >> value_from_register, that wraps up the composition of >> value_from_register and value_as_address? > > You mean something like the patch below? Tested on spu, s390-ibm-linux > and s390x-ibm-linux. Yes, that's great. Please commit. It seems a shame to be creating a value and then throwing it away, but the composition of those two functions has the semantics we want, so I don't see a good alternative without some more restructuring.