From: Jim Blandy <jimb@codesourcery.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Make insert_breakpoints return void.
Date: Thu, 29 Nov 2007 19:52:00 -0000 [thread overview]
Message-ID: <m31wa84yol.fsf@codesourcery.com> (raw)
In-Reply-To: <200711292156.37219.vladimir@codesourcery.com> (Vladimir Prus's message of "Thu, 29 Nov 2007 21:56:37 +0300")
Vladimir Prus <vladimir at codesourcery.com> writes:
> The insert_breakpoints function has 'int' as return
> type, and even tries to return something, but will
> never manage to -- because on the way to returning
> non-zero value it will always through an exception.
> This patch adjust the prototype to match the actual
> behaviour. OK?
>
> - Volodya
>
> * breakpoint.h (insert_breakpoints): Change
> return type to void.
> * breakpoint.c (insert_breakpoints): Change
> return type to void. Rename local return_val
> variable to error.
> * infrun.c (keep_going): Instead of checking
> return value from insert_breakpoints, catch exception.
Looks great. Please commit.
prev parent reply other threads:[~2007-11-29 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 18:56 Vladimir Prus
2007-11-29 19:52 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31wa84yol.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox