From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4937 invoked by alias); 29 Nov 2007 19:52:55 -0000 Received: (qmail 4920 invoked by uid 22791); 29 Nov 2007 19:52:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 29 Nov 2007 19:52:47 +0000 Received: (qmail 5981 invoked from network); 29 Nov 2007 19:52:45 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Nov 2007 19:52:45 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Make insert_breakpoints return void. References: <200711292156.37219.vladimir@codesourcery.com> From: Jim Blandy Date: Thu, 29 Nov 2007 19:52:00 -0000 In-Reply-To: <200711292156.37219.vladimir@codesourcery.com> (Vladimir Prus's message of "Thu, 29 Nov 2007 21:56:37 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00555.txt.bz2 Vladimir Prus writes: > The insert_breakpoints function has 'int' as return > type, and even tries to return something, but will > never manage to -- because on the way to returning > non-zero value it will always through an exception. > This patch adjust the prototype to match the actual > behaviour. OK? > > - Volodya > > * breakpoint.h (insert_breakpoints): Change > return type to void. > * breakpoint.c (insert_breakpoints): Change > return type to void. Rename local return_val > variable to error. > * infrun.c (keep_going): Instead of checking > return value from insert_breakpoints, catch exception. Looks great. Please commit.