Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Andreas Schwab <schwab@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix --with-system-readline vs. readline-6.0+
Date: Tue, 04 Aug 2009 17:42:00 -0000	[thread overview]
Message-ID: <m31vnrfpbq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3k51pgrbg.fsf@hase.home> (Andreas Schwab's message of "Fri\, 31 Jul 2009 11\:00\:35 +0200")

>>>>> "Andreas" == Andreas Schwab <schwab@redhat.com> writes:

Jan> After bundled readline gets upgraded to 6.0 this AC_DEFINE should
Jan> be reversed and tui/tui-io.c to be updated to use _rl_echoing_p of
Jan> the bundled version.

Andreas> Actually it should not use this internal variable at all.

Is there some nice way to do that?  Like, some exported readline API?

I'm inclined to approve this patch, on the theory that it will keep the
TUI working a while longer.  However, if there is a better possibility
we can use now, I won't.

Tom


  reply	other threads:[~2009-08-04 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 14:36 Jan Kratochvil
2009-07-31 14:37 ` Andreas Schwab
2009-08-04 17:42   ` Tom Tromey [this message]
2009-08-05  8:03     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31vnrfpbq.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=schwab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox