From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17976 invoked by alias); 4 Aug 2009 17:42:44 -0000 Received: (qmail 17967 invoked by uid 22791); 4 Aug 2009 17:42:43 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Aug 2009 17:42:37 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n74Hga8t011248 for ; Tue, 4 Aug 2009 13:42:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n74HgZXq007050; Tue, 4 Aug 2009 13:42:35 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n74HgYCw024899; Tue, 4 Aug 2009 13:42:34 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1F2F33784EC; Tue, 4 Aug 2009 11:42:34 -0600 (MDT) To: Andreas Schwab Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] Fix --with-system-readline vs. readline-6.0+ References: <20090731085253.GA5744@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 04 Aug 2009 17:42:00 -0000 In-Reply-To: (Andreas Schwab's message of "Fri\, 31 Jul 2009 11\:00\:35 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00054.txt.bz2 >>>>> "Andreas" == Andreas Schwab writes: Jan> After bundled readline gets upgraded to 6.0 this AC_DEFINE should Jan> be reversed and tui/tui-io.c to be updated to use _rl_echoing_p of Jan> the bundled version. Andreas> Actually it should not use this internal variable at all. Is there some nice way to do that? Like, some exported readline API? I'm inclined to approve this patch, on the theory that it will keep the TUI working a while longer. However, if there is a better possibility we can use now, I won't. Tom