From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Limit qualified completions
Date: Wed, 19 Aug 2009 22:02:00 -0000 [thread overview]
Message-ID: <m31vn78o1d.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4A8B3BB9.2070105@redhat.com> (Keith Seitz's message of "Tue, 18 Aug 2009 16:39:37 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> If the user attempts to complete symbols in a class or namespace,
Keith> i.e., "complete break foo::", default_make_symbol_completion_list will
Keith> return every single known global symbol in the executable.
Keith> This simplistic patch (and test case) "fixes" the problem, limiting
Keith> the matches to the appropriate symbols.
Keith> Ok?
I realize that Daniel already expressed some reservations about this
patch, in that it does not address all the scenarios. However, my view
is that this patch is an improvement over the current situation. I
asked Daniel about this off list and he seemed to be ok with moving
forward.
So, this is ok.
In addition to templates, I wonder what happens in this area if you try
to complete "Foo::~F" or a qualified Java name like "java.lang.Str".
Tom
next prev parent reply other threads:[~2009-08-19 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 1:14 Keith Seitz
2009-08-19 5:22 ` Daniel Jacobowitz
2009-08-19 22:02 ` Tom Tromey [this message]
2009-08-24 22:27 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vn78o1d.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox