From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15682 invoked by alias); 19 Aug 2009 21:57:50 -0000 Received: (qmail 15672 invoked by uid 22791); 19 Aug 2009 21:57:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Aug 2009 21:57:39 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLvaOI024272 for ; Wed, 19 Aug 2009 17:57:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLvaui031356; Wed, 19 Aug 2009 17:57:36 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7JLvZ94027193; Wed, 19 Aug 2009 17:57:35 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CA3F73782EF; Wed, 19 Aug 2009 15:57:34 -0600 (MDT) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Limit qualified completions References: <4A8B3BB9.2070105@redhat.com> Reply-To: tromey@redhat.com Date: Wed, 19 Aug 2009 22:02:00 -0000 In-Reply-To: <4A8B3BB9.2070105@redhat.com> (Keith Seitz's message of "Tue, 18 Aug 2009 16:39:37 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00318.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> If the user attempts to complete symbols in a class or namespace, Keith> i.e., "complete break foo::", default_make_symbol_completion_list will Keith> return every single known global symbol in the executable. Keith> This simplistic patch (and test case) "fixes" the problem, limiting Keith> the matches to the appropriate symbols. Keith> Ok? I realize that Daniel already expressed some reservations about this patch, in that it does not address all the scenarios. However, my view is that this patch is an improvement over the current situation. I asked Daniel about this off list and he seemed to be ok with moving forward. So, this is ok. In addition to templates, I wonder what happens in this area if you try to complete "Foo::~F" or a qualified Java name like "java.lang.Str". Tom