From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] clean-up of sym_read mainline flag (1/2)
Date: Mon, 30 Nov 2009 20:19:00 -0000 [thread overview]
Message-ID: <m31vjfsr41.fsf@fleche.redhat.com> (raw)
In-Reply-To: <41F206A6-E60C-4A55-B4F1-CC1C00626188@adacore.com> (Tristan Gingold's message of "Fri, 27 Nov 2009 11:20:09 +0100")
>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
Tristan> The mainline flag from sym_read routines was passed as argument
Tristan> to functions that doesn't use it. To clean-up a little bit and
Tristan> to make the code more readable, this patch removes this unused
Tristan> parameter.
This is almost ok.
Tristan> void
Tristan> -coffstab_build_psymtabs (struct objfile *objfile, int mainline,
Tristan> +coffstab_build_psymtabs (struct objfile *objfile,
Tristan> CORE_ADDR textaddr, unsigned int textsize,
I spot-checked and noticed that this function (and some others in this
file) documents the 'mainline' parameter in its header comment. These
comments must also be updated.
This is ok with that change. Please be sure to check all the functions,
thanks.
Tom
next prev parent reply other threads:[~2009-11-30 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 10:20 Tristan Gingold
2009-11-30 20:19 ` Tom Tromey [this message]
2009-12-02 11:37 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vjfsr41.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox