From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7098 invoked by alias); 30 Nov 2009 20:19:42 -0000 Received: (qmail 7086 invoked by uid 22791); 30 Nov 2009 20:19:41 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Nov 2009 20:19:35 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAUKJCY8009608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Nov 2009 15:19:12 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAUKJBp5015525; Mon, 30 Nov 2009 15:19:11 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAUKJAaU018424; Mon, 30 Nov 2009 15:19:11 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9577B37818D; Mon, 30 Nov 2009 13:19:10 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches ml Subject: Re: [RFA] clean-up of sym_read mainline flag (1/2) References: <41F206A6-E60C-4A55-B4F1-CC1C00626188@adacore.com> Reply-To: tromey@redhat.com Date: Mon, 30 Nov 2009 20:19:00 -0000 In-Reply-To: <41F206A6-E60C-4A55-B4F1-CC1C00626188@adacore.com> (Tristan Gingold's message of "Fri, 27 Nov 2009 11:20:09 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00602.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> The mainline flag from sym_read routines was passed as argument Tristan> to functions that doesn't use it. To clean-up a little bit and Tristan> to make the code more readable, this patch removes this unused Tristan> parameter. This is almost ok. Tristan> void Tristan> -coffstab_build_psymtabs (struct objfile *objfile, int mainline, Tristan> +coffstab_build_psymtabs (struct objfile *objfile, Tristan> CORE_ADDR textaddr, unsigned int textsize, I spot-checked and noticed that this function (and some others in this file) documents the 'mainline' parameter in its header comment. These comments must also be updated. This is ok with that change. Please be sure to check all the functions, thanks. Tom