From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] Platform agnostic dynamic loading code.
Date: Tue, 30 Aug 2011 18:40:00 -0000 [thread overview]
Message-ID: <m31uw2bv60.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4E5C7DC4.80709@playingwithpointers.com> (Sanjoy Das's message of "Tue, 30 Aug 2011 11:35:56 +0530")
>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
Sanjoy> * gdb/Makefile.in: Add gdb-dlfcn.c and gdb-dlfcn.h to build
Sanjoy> system.
Sanjoy> * gdb/config.in: Add new #define HAVE_DLFCN_H.
Sanjoy> * gdb/configure.ac: Add check for dlopen and for dlfcn.h
Sanjoy> * gdb/configure: Re-generated by autoconf.
Sanjoy> +AC_SEARCH_LIBS(dlopen, dl)
Sanjoy> +AC_CHECK_HEADERS([dlfcn.h])
There is one big call to AC_CHECK_HEADERS in gdb/configure.ac.
Search for "Checks for header files".
You should just add this header to that check; that is where all the
simple checks should go since having them in a single call makes the
resulting configure file smaller.
Sanjoy> +#include "gdb-dlfcn.h"
Sanjoy> +
Sanjoy> +#include "defs.h"
Put defs.h first.
This is ok with those changes. Thanks.
Tom
next prev parent reply other threads:[~2011-08-30 18:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 18:57 JIT Debug Info Reader (re-roll) Sanjoy Das
2011-08-24 18:57 ` [PATCH 1/7] Introduce jit-reader.in and modify build system Sanjoy Das
2011-08-24 18:57 ` [PATCH 5/7] Use the loaded reader Sanjoy Das
2011-08-24 18:57 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-29 10:03 ` Pedro Alves
2011-08-29 12:54 ` Sanjoy Das
2011-08-29 14:22 ` Pedro Alves
2011-08-30 6:01 ` Sanjoy Das
2011-08-30 18:40 ` Tom Tromey [this message]
2011-08-24 18:57 ` [PATCH 4/7] New commands for loading and unloading a reader Sanjoy Das
2011-08-24 18:57 ` [PATCH 2/7] Relocatable directory for loading JIT readers Sanjoy Das
2011-08-24 18:57 ` [PATCH 7/7] Documentation Sanjoy Das
2011-08-24 20:14 ` Eli Zaretskii
2011-08-24 18:57 ` [PATCH 6/7] New JIT unwinder Sanjoy Das
2011-08-24 19:04 ` Jan Kratochvil
2011-08-24 19:08 ` Sanjoy Das
2011-08-27 13:08 Sanjoy Das
[not found] ` <1314518609-10204-1-git-send-email-sanjoy@playingwithpointers.com>
2011-08-28 8:04 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-27 13:08 JIT Debug Info Reader Sanjoy Das
2011-08-27 13:08 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-31 3:31 JIT Reader (re-roll) Sanjoy Das
2011-08-31 3:31 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-31 4:01 ` Sanjoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31uw2bv60.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox