From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19893 invoked by alias); 30 Aug 2011 18:40:20 -0000 Received: (qmail 19884 invoked by uid 22791); 30 Aug 2011 18:40:20 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 18:40:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UIdrdW010371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 14:39:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7UIdr9c015090; Tue, 30 Aug 2011 14:39:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7UIdpwS030369; Tue, 30 Aug 2011 14:39:52 -0400 From: Tom Tromey To: Sanjoy Das Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Platform agnostic dynamic loading code. References: <1314212467-7391-1-git-send-email-sanjoy@playingwithpointers.com> <201108291103.23021.pedro@codesourcery.com> <4E5B8CFF.3060709@playingwithpointers.com> <201108291522.23175.pedro@codesourcery.com> <4E5C7DC4.80709@playingwithpointers.com> Date: Tue, 30 Aug 2011 18:40:00 -0000 In-Reply-To: <4E5C7DC4.80709@playingwithpointers.com> (Sanjoy Das's message of "Tue, 30 Aug 2011 11:35:56 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00626.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> * gdb/Makefile.in: Add gdb-dlfcn.c and gdb-dlfcn.h to build Sanjoy> system. Sanjoy> * gdb/config.in: Add new #define HAVE_DLFCN_H. Sanjoy> * gdb/configure.ac: Add check for dlopen and for dlfcn.h Sanjoy> * gdb/configure: Re-generated by autoconf. Sanjoy> +AC_SEARCH_LIBS(dlopen, dl) Sanjoy> +AC_CHECK_HEADERS([dlfcn.h]) There is one big call to AC_CHECK_HEADERS in gdb/configure.ac. Search for "Checks for header files". You should just add this header to that check; that is where all the simple checks should go since having them in a single call makes the resulting configure file smaller. Sanjoy> +#include "gdb-dlfcn.h" Sanjoy> + Sanjoy> +#include "defs.h" Put defs.h first. This is ok with those changes. Thanks. Tom