From: Andreas Schwab <schwab@linux-m68k.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] gdb_gcore man/help/install [+doc]
Date: Mon, 25 Apr 2011 08:37:00 -0000 [thread overview]
Message-ID: <m2tydm91fh.fsf@linux-m68k.org> (raw)
In-Reply-To: <20110425074138.GA5408@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 25 Apr 2011 09:41:39 +0200")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> --- a/gdb/gdb_gcore.sh
> +++ b/gdb/gdb_gcore.sh
> @@ -22,9 +22,9 @@
> # It starts up gdb, attaches to the given PID and invokes the gcore command.
> #
>
> -if [ "$#" -eq "0" ]
> +if [ "$#" -eq "0" -o "$1" = "-h" -o "$1" = "--help" ]
> then
> - echo "usage: gcore [-o filename] pid"
> + echo "usage: gcore [-o filename] pid1 [pid2...]"
+ echo "Usage: gcore [-o FILENAME] PID..."
> exit 2
--help should exit successfully. Also, test .. -o .. should be avoided.
case $#$1 in 0|1-h|1--help) ...
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-04-25 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 7:42 Jan Kratochvil
2011-04-25 8:37 ` Andreas Schwab [this message]
2011-04-25 8:43 ` Jan Kratochvil
2011-04-25 15:36 ` Tom Tromey
2011-04-26 20:00 ` Tom Tromey
2011-12-06 0:54 ` [patch] gdb_gcore man/help/install [+doc] #2 Jan Kratochvil
2011-12-20 14:42 ` Tom Tromey
2011-12-21 21:20 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tydm91fh.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox