From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80555-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4002 invoked by alias); 25 Apr 2011 08:37:21 -0000
Received: (qmail 3887 invoked by uid 22791); 25 Apr 2011 08:37:21 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Apr 2011 08:37:06 +0000
Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id 562D9188A170;	Mon, 25 Apr 2011 10:37:05 +0200 (CEST)
X-Auth-Info: S2kB7muNpdK0UaY6xI1V0NQbXroCFQA0/9nkC68UdYc=
Received: from linux.local (ppp-88-217-126-29.dynamic.mnet-online.de [88.217.126.29])	by mail.mnet-online.de (Postfix) with ESMTPA id 205041C00130;	Mon, 25 Apr 2011 10:32:05 +0200 (CEST)
Received: by linux.local (Postfix, from userid 501)	id A92091E52B5; Mon, 25 Apr 2011 10:32:03 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] gdb_gcore man/help/install [+doc]
References: <20110425074138.GA5408@host1.jankratochvil.net>
X-Yow: Catsup and Mustard all over the place!  It's the Human Hamburger!
Date: Mon, 25 Apr 2011 08:37:00 -0000
In-Reply-To: <20110425074138.GA5408@host1.jankratochvil.net> (Jan Kratochvil's	message of "Mon, 25 Apr 2011 09:41:39 +0200")
Message-ID: <m2tydm91fh.fsf@linux-m68k.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00437.txt.bz2

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> --- a/gdb/gdb_gcore.sh
> +++ b/gdb/gdb_gcore.sh
> @@ -22,9 +22,9 @@
>  # It starts up gdb, attaches to the given PID and invokes the gcore command.
>  #
>  
> -if [ "$#" -eq "0" ]
> +if [ "$#" -eq "0" -o "$1" = "-h" -o "$1" = "--help" ]
>  then
> -    echo "usage:  gcore [-o filename] pid"
> +    echo "usage:  gcore [-o filename] pid1 [pid2...]"
  +    echo "Usage:  gcore [-o FILENAME] PID..."
>      exit 2

--help should exit successfully.  Also, test .. -o .. should be avoided.

case $#$1 in 0|1-h|1--help) ...

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."