Add missing branchpoints to gdb.git?

Add missing branchpoints to gdb.git?

[Joel Brobecker]

Hello,

While working with the gdb git mirror, I noticed that it was missing
3 branchpoints. I was using a script that needs them, so I created
the tags in my repo. Should we create the tags in the reference git
mirror as well? Here are the associated SHA1s...

    gdb_7_2-2010-07-07-branchpoint: cd4c6c46d781fe20f1a73c9e07c0fbc05bfc8a0c
    gdb_7_1-2010-02-18-branchpoint: e16b3828eafec635405cc34beb8f08db117d7331
    gdb_7_0-2009-09-16-branchpoint: a4a5c910c73f0bf2b7d063912274461838139423

I would gladly create them, except that I don't think I have write
priviledges... Tom, maybe?

-- 
Joel

Re: Add missing branchpoints to gdb.git?

[Andreas Schwab]

Joel Brobecker <brobecker@adacore.com> writes:

>     gdb_7_2-2010-07-07-branchpoint: cd4c6c46d781fe20f1a73c9e07c0fbc05bfc8a0c
>     gdb_7_1-2010-02-18-branchpoint: e16b3828eafec635405cc34beb8f08db117d7331
>     gdb_7_0-2009-09-16-branchpoint: a4a5c910c73f0bf2b7d063912274461838139423

Actually, the real branch points are
b2f5cf460a3e550ab4032be1a90c752c0b9bdd9f,
9a4b7643da53df33552a50d9f02ddf5be5aef883,
fe78766a0c9eea331e2a1799027f2f7c8e990ff8, resp.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Add missing branchpoints to gdb.git?

[Joel Brobecker]

> >     gdb_7_2-2010-07-07-branchpoint: cd4c6c46d781fe20f1a73c9e07c0fbc05bfc8a0c
> >     gdb_7_1-2010-02-18-branchpoint: e16b3828eafec635405cc34beb8f08db117d7331
> >     gdb_7_0-2009-09-16-branchpoint: a4a5c910c73f0bf2b7d063912274461838139423
> 
> Actually, the real branch points are
> b2f5cf460a3e550ab4032be1a90c752c0b9bdd9f,
> 9a4b7643da53df33552a50d9f02ddf5be5aef883,
> fe78766a0c9eea331e2a1799027f2f7c8e990ff8, resp.

How did you come up with those commit IDs? I used `git merge-base',
and looking at the output, it seemed right. For instance, for the 7.2
branchpoint, I had cd4c6c46d781fe20f1a73c9e07c0fbc05bfc8a0c, which in
fact is a parent of the commit you are proposing. And since git confirms
that my commit is on the master branch as well, I figured it has to be
a more likely branchpoint?

-- 
Joel

Re: Add missing branchpoints to gdb.git?

[Andreas Schwab]

Joel Brobecker <brobecker@adacore.com> writes:

>> >     gdb_7_2-2010-07-07-branchpoint: cd4c6c46d781fe20f1a73c9e07c0fbc05bfc8a0c
>> >     gdb_7_1-2010-02-18-branchpoint: e16b3828eafec635405cc34beb8f08db117d7331
>> >     gdb_7_0-2009-09-16-branchpoint: a4a5c910c73f0bf2b7d063912274461838139423
>> 
>> Actually, the real branch points are
>> b2f5cf460a3e550ab4032be1a90c752c0b9bdd9f,
>> 9a4b7643da53df33552a50d9f02ddf5be5aef883,
>> fe78766a0c9eea331e2a1799027f2f7c8e990ff8, resp.
>
> How did you come up with those commit IDs?

By looking at the CVS tree.

> I used `git merge-base', and looking at the output, it seemed
> right.

The git tree is lying.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Add missing branchpoints to gdb.git?

[Tom Tromey]

Joel> I would gladly create them, except that I don't think I have write
Joel> priviledges... Tom, maybe?

I think you do have the permissions.

FWIW I usually do not mess with gdb.git myself, instead I contact Jim,
who set it up, to see whether the import process needs some fix.

Tom