Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Khoo Yit Phang <khooyp@cs.umd.edu>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	 Hui Zhu <teawater@gmail.com>,
	 gdb-patches@sourceware.org,  David Malcolm <dmalcolm@redhat.com>
Subject: Re: [patch] Re: Disable -lmcheck when Python has threads (Re: [BUG] gdb crash when "python import gtk")
Date: Fri, 31 Aug 2012 15:41:00 -0000	[thread overview]
Message-ID: <m2mx1bm5mg.fsf@igel.home> (raw)
In-Reply-To: <292C2B59-D40B-451F-B69B-0730BFB06619@cs.umd.edu> (Khoo Yit	Phang's message of "Fri, 31 Aug 2012 11:30:26 -0400")

Khoo Yit Phang <khooyp@cs.umd.edu> writes:

> +if test -z "${ENABLE_LIBMCHECK}" \
> +        -a \( "${have_libpython}" = "no" \
> +	     -o "${python_has_threads}" = "no" \) \

Such complicated test expressions are not portable, you should use
separate test invocations chained with || and &&.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2012-08-31 15:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CANFwon0wEXd+40H85veHyRTg+itYyL2jjgsCMYByxk5K0MTLHA@mail.gmail.com>
     [not found] ` <20120719073959.GA10044@host2.jankratochvil.net>
     [not found]   ` <A681786A-58A1-41E6-8410-8EBD8330E6BE@cs.umd.edu>
2012-08-30 16:43     ` Jan Kratochvil
2012-08-30 18:05       ` Khoo Yit Phang
2012-08-30 18:21         ` Jan Kratochvil
2012-08-30 18:58           ` Khoo Yit Phang
2012-08-30 19:05             ` Jan Kratochvil
2012-08-30 19:28               ` Khoo Yit Phang
2012-08-31  1:32                 ` Khoo Yit Phang
2012-08-31  8:14                   ` Jan Kratochvil
2012-08-31 15:30                     ` Khoo Yit Phang
2012-08-31 15:41                       ` Andreas Schwab [this message]
2012-08-31 16:08                         ` Khoo Yit Phang
2012-08-31 17:02                           ` Andreas Schwab
2012-08-31 18:03                             ` Khoo Yit Phang
2012-08-31 18:23                           ` Jan Kratochvil
2012-08-31 18:41                             ` Khoo Yit Phang
2012-09-02 15:37                               ` Jan Kratochvil
2012-09-06 19:31                                 ` Khoo Yit Phang
2012-08-30 18:22         ` Sergio Durigan Junior
2012-08-30 18:45           ` Khoo Yit Phang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2mx1bm5mg.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=dmalcolm@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=khooyp@cs.umd.edu \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox