From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19465 invoked by alias); 31 Aug 2012 15:41:19 -0000 Received: (qmail 19457 invoked by uid 22791); 31 Aug 2012 15:41:18 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Aug 2012 15:40:58 +0000 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3X7lCX63D8z4KK29; Fri, 31 Aug 2012 17:40:56 +0200 (CEST) X-Auth-Info: 9do2KsDr+EP5wmvjnW8yraNFoO9JkHsV6oICRgxVFYE= Received: from igel.home (ppp-88-217-116-91.dynamic.mnet-online.de [88.217.116.91]) by mail.mnet-online.de (Postfix) with ESMTPA id 3X7lCX4wHczbbgS; Fri, 31 Aug 2012 17:40:56 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 0FEE1CA2A3; Fri, 31 Aug 2012 17:40:55 +0200 (CEST) From: Andreas Schwab To: Khoo Yit Phang Cc: Jan Kratochvil , Hui Zhu , gdb-patches@sourceware.org, David Malcolm Subject: Re: [patch] Re: Disable -lmcheck when Python has threads (Re: [BUG] gdb crash when "python import gtk") References: <20120719073959.GA10044@host2.jankratochvil.net> <20120830164317.GA27381@host2.jankratochvil.net> <310D6419-544D-4D08-BB8B-21BC87C8241A@cs.umd.edu> <20120830182122.GA31421@host2.jankratochvil.net> <5C297339-3CCE-4350-9C7B-2C99B9FA01CA@cs.umd.edu> <20120830190523.GA781@host2.jankratochvil.net> <184D5CC3-BC35-4CA1-BE77-FC4D30D50E84@cs.umd.edu> <5567AD5F-AB82-4002-8A36-BFFF776093BD@cs.umd.edu> <20120831081353.GA23421@host2.jankratochvil.net> <292C2B59-D40B-451F-B69B-0730BFB06619@cs.umd.edu> X-Yow: This MUST be a good party -- My RIB CAGE is being painfully pressed up against someone's MARTINI!! Date: Fri, 31 Aug 2012 15:41:00 -0000 In-Reply-To: <292C2B59-D40B-451F-B69B-0730BFB06619@cs.umd.edu> (Khoo Yit Phang's message of "Fri, 31 Aug 2012 11:30:26 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00895.txt.bz2 Khoo Yit Phang writes: > +if test -z "${ENABLE_LIBMCHECK}" \ > + -a \( "${have_libpython}" = "no" \ > + -o "${python_has_threads}" = "no" \) \ Such complicated test expressions are not portable, you should use separate test invocations chained with || and &&. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."