* [PATCH] Test case on breakpoint-related notifications
@ 2012-09-25 6:02 Yao Qi
2012-09-28 21:28 ` Tom Tromey
2012-09-30 9:08 ` New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications] Jan Kratochvil
0 siblings, 2 replies; 6+ messages in thread
From: Yao Qi @ 2012-09-25 6:02 UTC (permalink / raw)
To: gdb-patches
Hi,
We don't have much test against breakpoint-related notifications
triggered by various situations. This patch is to add them.
This patch covers '=breakpoint-created'/'=breakpoint-deleted' for
various types of breakpoint, such as watchpoint, catchpoint and
dprintf. Patch only covers '=breakpoint-modified' when various
attributes of breakpoint are changed or pending breakpoint is
resolved. In gdb.mi/mi-breakpoint-changed.exp, I add a KFAIL because
modifying 'passcount' of tracepoint doesn't trigger
'=breakpoint-modified' notification, and I've opened PR 14617 for it.
OK to apply?
gdb/testsuite:
2012-09-25 Yao Qi <yao@codesourcery.com>
* gdb.trace/mi-tracepoint-changed.exp: New.
* gdb.mi/mi-breakpoint-changed.exp: New.
* gdb.mi/pending.c, gdb.mi/pendshr1.c: New
* gdb.mi/pendshr2.c: New.
---
gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 236 +++++++++++++++++++++
gdb/testsuite/gdb.mi/pending.c | 51 +++++
gdb/testsuite/gdb.mi/pendshr1.c | 29 +++
gdb/testsuite/gdb.mi/pendshr2.c | 26 +++
gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp | 221 +++++++++++++++++++
5 files changed, 563 insertions(+), 0 deletions(-)
create mode 100644 gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
create mode 100644 gdb/testsuite/gdb.mi/pending.c
create mode 100644 gdb/testsuite/gdb.mi/pendshr1.c
create mode 100644 gdb/testsuite/gdb.mi/pendshr2.c
create mode 100644 gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp
diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
new file mode 100644
index 0000000..c3abd74
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
@@ -0,0 +1,236 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if {[skip_shlib_tests]} {
+ return 0
+}
+
+load_lib mi-support.exp
+
+standard_testfile pending.c
+set libfile1 "pendshr1"
+set libfile2 "pendshr2"
+set executable $testfile
+set libsrc1 $srcdir/$subdir/$libfile1.c
+set libsrc2 $srcdir/$subdir/$libfile2.c
+set lib_sl1 [standard_output_file pendshr1.sl]
+set lib_sl2 [standard_output_file pendshr2.sl]
+set lib_opts "debug"
+
+if { [gdb_compile_shlib $libsrc1 $lib_sl1 $lib_opts] != ""
+ || [gdb_compile_shlib $libsrc2 $lib_sl2 $lib_opts] != ""} {
+ untested "Could not compile either $libsrc1 or $libsrc2"
+ return -1
+}
+
+set MIFLAGS "-i=mi"
+
+set exec_opts [list debug shlib=$lib_sl1 shlib_load]
+if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $exec_opts] != "" } {
+ untested "Failed to compile $srcfile"
+ return -1
+}
+
+proc test_insert_delete_modify { } {
+ global mi_gdb_prompt
+
+ gdb_exit
+ if [mi_gdb_start] {
+ continue
+ }
+
+ mi_run_to_main
+
+ mi_gdb_test "break marker" \
+ {(&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,bkpt=\{number="2",type="breakpoint".*\}.*\n\^done}
+
+ # Verify that '=breakpoint-modified' notification is correctly emitted:
+
+ # 1. when modifying command
+ send_gdb "commands\n"
+ gdb_expect {
+ -re "End with" {
+ }
+ }
+
+ send_gdb "silent\nend\n"
+ set test "change command"
+ gdb_expect {
+ -re ".*=breakpoint-modified.*${mi_gdb_prompt}$" {
+ pass $test
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+
+ # Verify that '=breakpoint-created' notification is correctly emittd when
+ # creating any type of breakpoint.
+
+ set test "watch watch"
+ mi_gdb_test ${test} \
+ {(&.*)*.*~".*atchpoint 3: .*\\n".*=breakpoint-created,bkpt=\{number="3",type="(hw |)watchpoint".*\}.*\n\^done} \
+ $test
+ set test "trace marker"
+ mi_gdb_test $test \
+ {(&.*)*.*~"Tracepoint 4 at .*\\n".*=breakpoint-created,bkpt=\{number="4",type="tracepoint".*\}.*\n\^done} \
+ $test
+ set test "catch syscall"
+ mi_gdb_test $test \
+ {(&.*)*.*~"Catchpoint 5 .*\\n".*=breakpoint-created,bkpt=\{number="5",type="catchpoint".*\}.*\n\^done} \
+ $test
+ set test "dprintf marker, \"arg\" \""
+ mi_gdb_test $test \
+ {.*=breakpoint-created,bkpt=\{number="6",type="dprintf".*\}.*\n\^done} \
+ $test
+
+ # 2. when modifying condition
+ set test "condition 2 main > 0x0"
+ mi_gdb_test $test \
+ {.*=breakpoint-modified,bkpt=\{number="2",.*,cond=\"main > 0x0\".*\}.*\n\^done} \
+ $test
+
+ # 3. when modifying enableness
+ set test "disable 3"
+ mi_gdb_test $test \
+ {.*=breakpoint-modified,bkpt=\{number="3",.*,enabled=\"n\".*\}.*\n\^done} \
+ $test
+ set test "enable 3"
+ mi_gdb_test $test \
+ {.*=breakpoint-modified,bkpt=\{number="3",.*,enabled=\"y\".*\}.*\n\^done} \
+ $test
+ # 4. when modifying ignore count.
+ set test "ignore 5 1"
+ mi_gdb_test $test \
+ {.*=breakpoint-modified,bkpt=\{number="5",.*,ignore=\"1\".*\}.*\n\^done} \
+ $test
+ # 5. when modifying pass count.
+ setup_kfail gdb/14617 *-*-*
+ set test "passcount 1 4"
+ mi_gdb_test $test \
+ {.*=breakpoint-modified,bkpt=\{number="4",.*\}.*\n\^done} \
+ $test
+
+ # Delete some breakpoints and verify that '=breakpoint-deleted
+ # notification is correctly emitted.
+ for {set i 3} {$i < 7} {incr i} {
+ mi_gdb_test "delete ${i}" ".*=breakpoint-deleted,id=\"${i}\".*\\^done" \
+ "delete ${i}"
+ }
+}
+
+test_insert_delete_modify
+
+# Test 'breakpoint-modified' notification is emited when pending breakpoints are
+# resolved.
+
+proc test_pending_resolved { } { with_test_prefix "pending resolved" {
+ global decimal hex
+ global srcdir
+ global subdir
+ global binfile
+ global lib_sl1 lib_sl2
+ global mi_gdb_prompt
+
+ gdb_exit
+ if [mi_gdb_start] {
+ continue
+ }
+ mi_gdb_reinitialize_dir $srcdir/$subdir
+ mi_gdb_load ${binfile}
+ mi_load_shlibs $lib_sl1 $lib_sl2
+
+ # Create a pending breakpoint on pendfunc1
+ mi_gdb_test "-break-insert -f pendfunc1" \
+ {.*\^done,bkpt=.*addr=\"<PENDING>\".*} \
+ "insert breakpoint on pendfunc1"
+ mi_run_cmd
+
+ set test "breakpoint on pendfunc1 resolved"
+ gdb_expect {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"0\".*" {
+ pass $test
+ exp_continue
+ }
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"1\".*" {
+ pass "$test: hit_count is updated"
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+ mi_expect_stop "breakpoint-hit" "pendfunc1" ""\
+ ".*" ".*" {"" "disp=\"keep\""} \
+ "continue to pendfunc1 breakpoint"
+
+ # Delete breakpoint on pendfunc1
+ mi_gdb_test "-break-delete 1" {\^done} \
+ "delete breakpoint on pendfunc1"
+ # Insert breakpoint on marker
+ mi_gdb_test "-break-insert marker" {.*\^done,bkpt=.*} \
+ "insert breakpoint on marker"
+ # Create a pending breakpoint on pendfunc3
+ mi_gdb_test "-break-insert -f pendfunc3" \
+ {.*\^done,bkpt=.*addr=\"<PENDING>\".*} \
+ "insert breakpoint on pendfunc3"
+
+ mi_execute_to "exec-continue" "breakpoint-hit" "marker" ".*" ".*" ".*" \
+ {"" "disp=\"keep\""} "continue to marker 1"
+
+ mi_send_resuming_command "exec-continue" "continuing execution to marker"
+
+ set test "breakpoint on pendfunc3 resolved"
+ gdb_expect {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"2\".*addr=\"${hex}\",.*func=\"marker\",.*times=\"1\"" {
+ pass "$test: hit_count is updated"
+ exp_continue
+ }
+ -re ".*=breakpoint-modified,bkpt=\{number=\"3\".*addr=\"${hex}\",.*func=\"pendfunc3\",.*times=\"0\"" {
+ pass $test
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+ mi_expect_stop "breakpoint-hit" "marker" ".*" ".*" ".*" \
+ {"" "disp=\"keep\""} "continue to marker 2"
+
+ mi_send_resuming_command "exec-continue" "continuing to exit"
+ set test "breakpoint on pendfunc3 pending again"
+ gdb_expect {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"3\".*addr=\"<PENDING>\".*" {
+ pass $test
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+
+ mi_expect_stop "exited-normally" "" "" "" "" "" ""
+}}
+
+test_pending_resolved
diff --git a/gdb/testsuite/gdb.mi/pending.c b/gdb/testsuite/gdb.mi/pending.c
new file mode 100644
index 0000000..7c78a4b
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/pending.c
@@ -0,0 +1,51 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2011-2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <stdio.h>
+#include <dlfcn.h>
+
+extern void pendfunc (int x);
+int watch = 0;
+
+static void
+marker () {}
+
+int main()
+{
+ const char *libname = "pendshr2.sl";
+ void *h;
+ int (*p_func) (int);
+
+ pendfunc (3);
+ pendfunc (4);
+ pendfunc (3);
+
+ marker ();
+
+ h = dlopen (libname, RTLD_LAZY);
+ if (h == NULL) return 1;
+
+ p_func = dlsym (h, "pendfunc2");
+ if (p_func == NULL) return 2;
+
+ (*p_func) (4);
+
+ marker ();
+
+ dlclose (h);
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.mi/pendshr1.c b/gdb/testsuite/gdb.mi/pendshr1.c
new file mode 100644
index 0000000..a56ae29
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/pendshr1.c
@@ -0,0 +1,29 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2011-2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+static void
+pendfunc1 (void)
+{
+ int x = 0;
+ int y = x + 4;
+}
+
+void
+pendfunc (int x)
+{
+ pendfunc1 ();
+}
diff --git a/gdb/testsuite/gdb.mi/pendshr2.c b/gdb/testsuite/gdb.mi/pendshr2.c
new file mode 100644
index 0000000..9770d1a
--- /dev/null
+++ b/gdb/testsuite/gdb.mi/pendshr2.c
@@ -0,0 +1,26 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2011-2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+void
+pendfunc2 (int x)
+{
+}
+
+void
+pendfunc3 (int y)
+{
+}
diff --git a/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp b/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp
new file mode 100644
index 0000000..aa386bb
--- /dev/null
+++ b/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp
@@ -0,0 +1,221 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+load_lib trace-support.exp
+
+if {[skip_shlib_tests]} {
+ return 0
+}
+
+standard_testfile pending.c
+set libfile1 "pendshr1"
+set libfile2 "pendshr2"
+set executable $testfile
+set libsrc1 $srcdir/$subdir/$libfile1.c
+set libsrc2 $srcdir/$subdir/$libfile2.c
+set lib_sl1 [standard_output_file pendshr1.sl]
+set lib_sl2 [standard_output_file pendshr2.sl]
+
+set lib_opts [gdb_target_symbol_prefix_flags]
+
+if { [gdb_compile_shlib $libsrc1 $lib_sl1 $lib_opts] != ""
+ || [gdb_compile_shlib $libsrc2 $lib_sl2 $lib_opts] != ""} {
+ untested "Could not compile either $libsrc1 or $libsrc2"
+ return -1
+}
+
+set exec_opts [list debug shlib=$lib_sl1 shlib_load]
+if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $exec_opts] != "" } {
+ untested "Failed to compile $srcfile"
+ return -1
+}
+
+load_lib mi-support.exp
+set MIFLAGS "-i=mi"
+
+# Test when GDB connects to a disconnected stub, existing tracepoints in
+# remote stub can be uploaded to GDB, and GDB emits MI notification if
+# new tracepoints are created.
+
+proc test_reconnect { } { with_test_prefix "reconnect" {
+
+ global gdbserver_reconnect_p
+ global gdb_prompt
+ global executable
+ global lib_sl1 lib_sl2
+
+ set gdbserver_reconnect_p 1
+ if { [info proc gdb_reconnect] == "" } {
+ return 0
+ }
+
+ clean_restart $executable
+ gdb_load_shlibs $lib_sl1
+ gdb_load_shlibs $lib_sl2
+ if ![runto_main] then {
+ fail "Can't run to main"
+ return 0
+ }
+ gdb_test "trace marker" "Tracepoint.*at.* file .*" \
+ "tracepointpoint on marker"
+ gdb_test_no_output "tstart" "start trace experiment"
+
+ set test "disconnect"
+ gdb_test_multiple "disconnect" $test {
+ -re "Trace is running but will stop on detach; detach anyway\\? \\(y or n\\) $" {
+ pass $test
+
+ set test "disconnected"
+ gdb_test_multiple "y" $test {
+ -re "$gdb_prompt $" {
+ pass "$test"
+ }
+ }
+ }
+ }
+
+ gdb_exit
+
+ if [mi_gdb_start] {
+ return
+ }
+
+ global srcdir
+ global subdir
+ global binfile
+
+ mi_gdb_reinitialize_dir $srcdir/$subdir
+ mi_gdb_load ${binfile}
+
+ global gdbserver_protocol
+ global gdbserver_gdbport
+
+ send_gdb "47-target-select $gdbserver_protocol $gdbserver_gdbport\n"
+
+ global mi_gdb_prompt
+ set test "tracepoint created"
+ gdb_expect {
+ -re "=breakpoint-created,bkpt=\{number=\"1\",type=\"tracepoint\",disp=\"keep\",enabled=\"y\",.*,func=\"marker\".*${mi_gdb_prompt}" {
+ pass $test
+ }
+ timeout {
+ fail $test
+ }
+ }
+
+ set gdbserver_reconnect_p 0
+}}
+
+
+# Test 'breakpoint-modified' notification is emited when pending tracepoints are
+# resolved.
+
+proc test_pending_resolved { } { with_test_prefix "pending resolved" {
+ global decimal hex
+ global executable
+ global srcdir
+ global subdir
+ global binfile
+ global lib_sl1 lib_sl2
+ global mi_gdb_prompt
+
+ gdb_exit
+ if [mi_gdb_start] {
+ continue
+ }
+
+ mi_gdb_reinitialize_dir $srcdir/$subdir
+ mi_gdb_load ${binfile}
+ mi_load_shlibs $lib_sl1 $lib_sl2
+
+ # Create a pending tracepoint on pendfunc2
+ mi_gdb_test "-break-insert -a -f pendfunc2" \
+ {.*\^done,bkpt=.*addr=\"<PENDING>\".*} \
+ "insert breakpoint on pendfunc2"
+ # Insert breakpoint on marker
+ mi_gdb_test "-break-insert marker" {.*\^done,bkpt=.*} \
+ "insert breakpoint on marker"
+
+ mi_run_cmd
+ mi_expect_stop "breakpoint-hit" "marker" ""\
+ ".*" ".*" {"" "disp=\"keep\""} \
+ "continue to marker breakpoint"
+ mi_gdb_test "-trace-start" {\^done} "trace start"
+
+ mi_send_resuming_command "exec-continue" "continuing execution to marker 1"
+
+ set test "tracepoint on pendfunc2 resolved"
+ gdb_expect {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\",type=\"tracepoint\".*.*times=\"0\"" {
+ pass "$test"
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+ mi_expect_stop "breakpoint-hit" "marker" ".*" ".*" ".*" \
+ {"" "disp=\"keep\""} "continue to marker"
+
+
+ mi_gdb_test "-trace-stop" {\^done,.*} "trace stop"
+ mi_gdb_test "-trace-find frame-number 0" \
+ "-trace-find frame-number 0\r\n\\^done,found=\"1\",tracepoint=\"${decimal}\",traceframe=\"0\",frame=\{.*" \
+ "-trace-find frame-number 0"
+ mi_gdb_test "-trace-find none" {\^done,found="0"} "back to live inferior"
+
+ mi_send_resuming_command "exec-continue" "continuing to exit"
+ set test "tracepoint on pendfunc2 becomes pending again"
+ gdb_expect {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\",type=\"tracepoint\".*addr=\"<PENDING>\",.*times=\"0\"" {
+ pass "$test"
+ }
+ -re ".*${mi_gdb_prompt}$" {
+ fail $test
+ }
+ timeout {
+ fail "$test (timeout)"
+ }
+ }
+
+ mi_expect_stop "exited-normally" "" "" "" "" "" ""
+}}
+
+# Test target supports tracepoints or not.
+
+clean_restart $executable
+
+gdb_load_shlibs $lib_sl1
+gdb_load_shlibs $lib_sl2
+
+if ![runto_main] {
+ fail "Can't run to main to check for trace support"
+ return -1
+}
+
+if ![gdb_target_supports_trace] {
+ unsupported "Current target does not support trace"
+ return -1;
+}
+
+gdb_exit
+
+test_reconnect
+
+test_pending_resolved
+
+return 0
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Test case on breakpoint-related notifications
2012-09-25 6:02 [PATCH] Test case on breakpoint-related notifications Yao Qi
@ 2012-09-28 21:28 ` Tom Tromey
2012-09-30 9:08 ` New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications] Jan Kratochvil
1 sibling, 0 replies; 6+ messages in thread
From: Tom Tromey @ 2012-09-28 21:28 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2012-09-25 Yao Qi <yao@codesourcery.com>
Yao> * gdb.trace/mi-tracepoint-changed.exp: New.
Yao> * gdb.mi/mi-breakpoint-changed.exp: New.
Yao> * gdb.mi/pending.c, gdb.mi/pendshr1.c: New
Yao> * gdb.mi/pendshr2.c: New.
Looks good to me. Thanks for writing this.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications]
2012-09-25 6:02 [PATCH] Test case on breakpoint-related notifications Yao Qi
2012-09-28 21:28 ` Tom Tromey
@ 2012-09-30 9:08 ` Jan Kratochvil
2012-09-30 9:25 ` Andreas Schwab
2012-10-07 12:16 ` Yao Qi
1 sibling, 2 replies; 6+ messages in thread
From: Jan Kratochvil @ 2012-09-30 9:08 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On Tue, 25 Sep 2012 08:01:04 +0200, Yao Qi wrote:
> * gdb.mi/mi-breakpoint-changed.exp: New.
Getting many racy results during nightly run:
-PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to pendfunc1 breakpoint
+FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to pendfunc1 breakpoint (timeout)
and
-PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved: hit_count is updated
-PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to pendfunc1 breakpoint
+FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved (timeout)
+FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to pendfunc1 breakpoint (timeout)
and
-FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: delete breakpoint on pendfunc1
+PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: delete breakpoint on pendfunc1
and
-PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved:
+FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: (unknown output after running)
I do not have it reproducible, even PR 12649 'read1' does not work for it.
It looks like:
=library-loaded,id="/lib/libc.so.6",target-name="/lib/libc.so.6",host-name="/lib/libc.so.6",symbols-loaded="0",thread-group="i1"^M
-=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="0",original-location="pendfunc1"}PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved
-^M
+=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="0",original-location="pendfunc1"}^M
=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="1",original-location="pendfunc1"}^M
-*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame={addr="0xf7fd8502",func="pendfunc1",args=[],file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21"},thread-id="1",stopped-threads="all",core="5"^M
-(gdb) PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved: hit_count is updated
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame={addr="0xf7fd8502",func="pendfunc1",args=[],file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21"},thread-id="1",stopped-threads="all",core="2"^M
+(gdb) ^M
+PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved
+FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved (timeout)
mi_expect_stop: expecting: \*stopped,reason="breakpoint-hit",disp="keep",bkptno="[0-9]+",frame={addr="0x[0-9A-Fa-f]+",func="pendfunc1",args=\[\],(?:file="[^
]*.*",fullname="(/[^\n]*/|\\\\[^\\]+\\[^\n]+\\|\\[^\\][^\n]*\\|[a-zA-Z]:[^\n]*\\).*",line=".*"|from=".*")},thread-id="[0-9]+",stopped-threads=[^
]*^M
(=thread-selected,id="[0-9]+"^M
|=(?:breakpoint-created|breakpoint-deleted)[^
]+"^M
)*[(]gdb[)] ^M
$
-^M
FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to pendfunc1 breakpoint (timeout)
Expecting: ^(-break-delete 1[^M
]+)?(\^done[^M
]+[(]gdb[)] ^M
[ ]*)
-break-delete 1^M
^done^M
(gdb) ^M
-FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: delete breakpoint on pendfunc1
+PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: delete breakpoint on pendfunc1
Expecting: ^(-break-insert marker[^M
and
+=breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x0804869f",func="marker",file="gdb/testsuite/gdb.mi/pending.c",fullname="/unsafegdb/testsuite/gdb.mi/pending.c",line="25",times="2",original-location="marker"}^M
+*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame={addr="0x0804869f",func="marker",args=[],file="gdb/testsuite/gdb.mi/pending.c",fullname="/unsafegdb/testsuite/gdb.mi/pending.c",line="25"},thread-id="1",stopped-threads="all",core="2"^M
+(gdb) ^M
PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: continue to marker 2
-exec-continue^M
^running^M
*running,thread-id="1"^M
(gdb) ^M
=library-unloaded,id="/unsafegdb/testsuite.unix.-m32/gdb.mi/pendshr2.sl",target-name="/unsafegdb/testsuite.unix.-m32/gdb.mi/pendshr2.sl",host-name="/unsafegdb/testsuite.unix.-m32/gdb.mi/pendshr2.sl",thread-group="i1"^M
=breakpoint-modified,bkpt={number="3",type="breakpoint",disp="keep",enabled="y",addr="<PENDING>",pending="pendfunc3",times="0",original-location="pendfunc3"}^M
&"warning: Temporarily disabling breakpoints for unloaded shared library \"/unsafegdb/testsuite.unix.-m32/gdb.mi/pendshr2.sl\"\n"^M
=thread-exited,id="1",group-id="i1"^M
=thread-group-exited,id="i1",exit-code="0"^M
*stopped,reason="exited-normally"^M
(gdb) ^M
PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc3 pending again
FAIL: gdb.mi/mi-breakpoint-changed.exp: pending resolved: (unknown output after running)
-testcase gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp completed in 22 seconds
+testcase gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp completed in 31 seconds
etc.
Do you have an idea for a fix?
Thanks,
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications]
2012-09-30 9:08 ` New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications] Jan Kratochvil
@ 2012-09-30 9:25 ` Andreas Schwab
2012-10-07 12:16 ` Yao Qi
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2012-09-30 9:25 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: Yao Qi, gdb-patches
Every ".*" should to be changed to "[^\n]*".
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications]
2012-09-30 9:08 ` New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications] Jan Kratochvil
2012-09-30 9:25 ` Andreas Schwab
@ 2012-10-07 12:16 ` Yao Qi
2012-10-11 7:21 ` Jan Kratochvil
1 sibling, 1 reply; 6+ messages in thread
From: Yao Qi @ 2012-10-07 12:16 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: gdb-patches
On 09/30/2012 05:07 PM, Jan Kratochvil wrote:
> I do not have it reproducible, even PR 12649 'read1' does not work for it.
> It looks like:
>
> =library-loaded,id="/lib/libc.so.6",target-name="/lib/libc.so.6",host-name="/lib/libc.so.6",symbols-loaded="0",thread-group="i1"^M
> -=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="0",original-location="pendfunc1"}PASS: gdb.mi/mi-breakpoint-changed.exp: pending resolved: breakpoint on pendfunc1 resolved
> -^M
> +=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="0",original-location="pendfunc1"}^M
> =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xf7fd8502",func="pendfunc1",file="gdb/testsuite/gdb.mi/pendshr1.c",fullname="/unsafegdb/testsuite/gdb.mi/pendshr1.c",line="21",times="1",original-location="pendfunc1"}^M
I can't reproduce it either on my system. However, it looks like fail
is caused by some trail ".*" in patterns, because trail ".*" is
ambiguous on how many characters will be matched. The patch below
should fix the fail.
--
Yao
gdb/testsuite:
2012-10-07 Yao Qi <yao@codesourcery.com>
* gdb.mi/mi-breakpoint-changed.exp (test_pending_resolved): Remove
trail '.*' on matching patterns.
---
gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
index c3abd74..773f588 100644
--- a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
+++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
@@ -163,11 +163,11 @@ proc test_pending_resolved { } { with_test_prefix "pending resolved" {
set test "breakpoint on pendfunc1 resolved"
gdb_expect {
- -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"0\".*" {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"0\"" {
pass $test
exp_continue
}
- -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"1\".*" {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"1\".*addr=\"${hex}\".*,times=\"1\"" {
pass "$test: hit_count is updated"
}
-re ".*${mi_gdb_prompt}$" {
@@ -219,7 +219,7 @@ proc test_pending_resolved { } { with_test_prefix "pending resolved" {
mi_send_resuming_command "exec-continue" "continuing to exit"
set test "breakpoint on pendfunc3 pending again"
gdb_expect {
- -re ".*=breakpoint-modified,bkpt=\{number=\"3\".*addr=\"<PENDING>\".*" {
+ -re ".*=breakpoint-modified,bkpt=\{number=\"3\".*addr=\"<PENDING>\"" {
pass $test
}
-re ".*${mi_gdb_prompt}$" {
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications]
2012-10-07 12:16 ` Yao Qi
@ 2012-10-11 7:21 ` Jan Kratochvil
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kratochvil @ 2012-10-11 7:21 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On Sun, 07 Oct 2012 14:16:21 +0200, Yao Qi wrote:
> I can't reproduce it either on my system. However, it looks like fail
> is caused by some trail ".*" in patterns, because trail ".*" is
> ambiguous on how many characters will be matched. The patch below
> should fix the fail.
>
> --
> Yao
>
> gdb/testsuite:
>
> 2012-10-07 Yao Qi <yao@codesourcery.com>
>
> * gdb.mi/mi-breakpoint-changed.exp (test_pending_resolved): Remove
> trail '.*' on matching patterns.
It seems to fix the problem, please check it in.
Thanks,
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-11 7:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-25 6:02 [PATCH] Test case on breakpoint-related notifications Yao Qi
2012-09-28 21:28 ` Tom Tromey
2012-09-30 9:08 ` New gdb.mi/mi-breakpoint-changed.exp racy results [Re: [PATCH] Test case on breakpoint-related notifications] Jan Kratochvil
2012-09-30 9:25 ` Andreas Schwab
2012-10-07 12:16 ` Yao Qi
2012-10-11 7:21 ` Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox