* Only use ranged watchpoints when supported
@ 2011-12-18 6:18 Andreas Schwab
2011-12-21 4:53 ` Thiago Jung Bauermann
2011-12-21 13:47 ` Ulrich Weigand
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Schwab @ 2011-12-18 6:18 UTC (permalink / raw)
To: gdb-patches; +Cc: Ulrich Weigand, Thiago Jung Bauermann, Sergio Durigan Junior
This fixes all watchpoint regressions.
Andreas.
2011-12-18 Andreas Schwab <schwab@linux-m68k.org>
* ppc-linux-nat.c (create_watchpoint_request): Only use ranged
watchpoints when supported.
---
gdb/ppc-linux-nat.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c
index dc7f152..cc29ad8 100644
--- a/gdb/ppc-linux-nat.c
+++ b/gdb/ppc-linux-nat.c
@@ -2010,7 +2010,8 @@ create_watchpoint_request (struct ppc_hw_breakpoint *p, CORE_ADDR addr,
int len, int rw, struct expression *cond,
int insert)
{
- if (len == 1)
+ if (len == 1
+ || !(booke_debug_info.features & PPC_DEBUG_FEATURE_DATA_BP_RANGE))
{
int use_condition;
CORE_ADDR data_value;
--
1.7.8
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Only use ranged watchpoints when supported
2011-12-18 6:18 Only use ranged watchpoints when supported Andreas Schwab
@ 2011-12-21 4:53 ` Thiago Jung Bauermann
2011-12-21 13:47 ` Ulrich Weigand
1 sibling, 0 replies; 3+ messages in thread
From: Thiago Jung Bauermann @ 2011-12-21 4:53 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gdb-patches, Ulrich Weigand
Hi Andreas,
On Sun, 2011-12-18 at 02:14 +0100, Andreas Schwab wrote:
> This fixes all watchpoint regressions.
It looks good to me. Thanks!
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Only use ranged watchpoints when supported
2011-12-18 6:18 Only use ranged watchpoints when supported Andreas Schwab
2011-12-21 4:53 ` Thiago Jung Bauermann
@ 2011-12-21 13:47 ` Ulrich Weigand
1 sibling, 0 replies; 3+ messages in thread
From: Ulrich Weigand @ 2011-12-21 13:47 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gdb-patches, Thiago Jung Bauermann, Sergio Durigan Junior
Andreas Schwab wrote:
> 2011-12-18 Andreas Schwab <schwab@linux-m68k.org>
>
> * ppc-linux-nat.c (create_watchpoint_request): Only use ranged
> watchpoints when supported.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-21 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-18 6:18 Only use ranged watchpoints when supported Andreas Schwab
2011-12-21 4:53 ` Thiago Jung Bauermann
2011-12-21 13:47 ` Ulrich Weigand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox