Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] is_name_suffix("") is always non-zero
Date: Sat, 26 Feb 2011 22:21:00 -0000	[thread overview]
Message-ID: <m27hcmsapy.fsf@igel.home> (raw)

is_name_suffix always returns non-zero when called with the empty
string.  Probably this should be called with string1 instead.

Andreas.

2011-02-26  Andreas Schwab  <schwab@linux-m68k.org>

	* ada-lang.c (compare_names): Call is_name_suffix with string1
	instead of string2.

--- gdb/ada-lang.c.~1.284.~	2011-01-21 20:20:53.000000000 +0100
+++ gdb/ada-lang.c	2011-02-26 23:00:31.000000000 +0100
@@ -4740,7 +4740,7 @@ compare_names (const char *string1, cons
     case '_':
       if (*string2 == '\0')
 	{
-	  if (is_name_suffix (string2))
+	  if (is_name_suffix (string1))
 	    return 0;
 	  else
 	    return -1;

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


             reply	other threads:[~2011-02-26 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 22:21 Andreas Schwab [this message]
2011-02-28  4:50 ` Joel Brobecker
2011-02-28  9:51   ` Andreas Schwab
2011-03-07 10:24 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27hcmsapy.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox