From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78739-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14521 invoked by alias); 26 Feb 2011 22:16:36 -0000
Received: (qmail 14512 invoked by uid 22791); 26 Feb 2011 22:16:36 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 22:16:30 +0000
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id B4B751C0F57E	for <gdb-patches@sourceware.org>; Sat, 26 Feb 2011 23:16:27 +0100 (CET)
Received: from localhost (dynscan1.mnet-online.de [192.168.8.164])	by mail.m-online.net (Postfix) with ESMTP id 5DB161C00106	for <gdb-patches@sourceware.org>; Sat, 26 Feb 2011 23:16:27 +0100 (CET)
Received: from mail.mnet-online.de ([192.168.8.180])	by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024)	with ESMTP id lFG7GQrZoGRJ for <gdb-patches@sourceware.org>;	Sat, 26 Feb 2011 23:16:26 +0100 (CET)
Received: from igel.home (ppp-93-104-114-54.dynamic.mnet-online.de [93.104.114.54])	by mail.mnet-online.de (Postfix) with ESMTP	for <gdb-patches@sourceware.org>; Sat, 26 Feb 2011 23:16:26 +0100 (CET)
Received: by igel.home (Postfix, from userid 501)	id DC0E6CA2A0; Sat, 26 Feb 2011 23:16:25 +0100 (CET)
From: Andreas Schwab <schwab@linux-m68k.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] is_name_suffix("") is always non-zero
X-Yow: Yow!  I like my new DENTIST...
Date: Sat, 26 Feb 2011 22:21:00 -0000
Message-ID: <m27hcmsapy.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.94 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00806.txt.bz2

is_name_suffix always returns non-zero when called with the empty
string.  Probably this should be called with string1 instead.

Andreas.

2011-02-26  Andreas Schwab  <schwab@linux-m68k.org>

	* ada-lang.c (compare_names): Call is_name_suffix with string1
	instead of string2.

--- gdb/ada-lang.c.~1.284.~	2011-01-21 20:20:53.000000000 +0100
+++ gdb/ada-lang.c	2011-02-26 23:00:31.000000000 +0100
@@ -4740,7 +4740,7 @@ compare_names (const char *string1, cons
     case '_':
       if (*string2 == '\0')
 	{
-	  if (is_name_suffix (string2))
+	  if (is_name_suffix (string1))
 	    return 0;
 	  else
 	    return -1;

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."