Re: [RFA] remote debugging patches

[Andreas Schwab <schwab@suse.de>]

Michal Ludvig <mludvig@suse.cz> writes:

|> Daniel Jacobowitz wrote:
|> > Michal, are you OK with just the IP address?
|> 
|> Sure I am :-) Patch follows... Is it OK?
|> 
|> Index: ChangeLog
|> 	* remote-utils.c (remote_open): Print remote-side's
|> 	IP address when remote debugging over the network.
|> 
|> Index: remote-utils.c
|> ===================================================================
|> RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v
|> retrieving revision 1.8
|> diff -c -3 -p -r1.8 remote-utils.c
|> *** remote-utils.c      2002/02/14 06:21:22     1.8
|> --- remote-utils.c      2002/03/13 14:11:16
|> *************** static int remote_desc;
|> *** 47,53 ****
|>    void
|>    remote_open (char *name)
|>    {
|> !   int save_fcntl_flags;
|> 
|>      if (!strchr (name, ':'))
|>        {
|> --- 47,56 ----
|>    void
|>    remote_open (char *name)
|>    {
|> !   int save_fcntl_flags, via_network=0;;
|> !   char namebuf[100];
|> !
|> !   snprintf(namebuf, 100, "%s", name);

Why are you truncating the name to 100 characters?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."