From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13338-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 26113 invoked by alias); 13 Mar 2002 15:48:51 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26055 invoked from network); 13 Mar 2002 15:48:48 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by sources.redhat.com with SMTP; 13 Mar 2002 15:48:48 -0000
Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136])
	by Cantor.suse.de (Postfix) with ESMTP
	id AE8011E586; Wed, 13 Mar 2002 16:48:47 +0100 (MET)
X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f
To: Michal Ludvig <mludvig@suse.cz>
Cc: Daniel Jacobowitz <drow@mvista.com>,
	Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] remote debugging patches
References: <3C8BA71F.20807@suse.cz> <20020310143517.B3933@nevyn.them.org>
	<3C8BB74D.90705@suse.cz> <20020310173046.C9299@nevyn.them.org>
	<3C8CC514.4010207@suse.cz> <3C8D6646.8030809@cygnus.com>
	<20020311214743.B462@nevyn.them.org> <3C8F5EA6.9050909@suse.cz>
X-Yow: I wish I was on a Cincinnati street corner holding a clean dog!
From: Andreas Schwab <schwab@suse.de>
Date: Wed, 13 Mar 2002 07:48:00 -0000
In-Reply-To: <3C8F5EA6.9050909@suse.cz> (Michal Ludvig's message of "Wed, 13
 Mar 2002 15:13:58 +0100")
Message-ID: <jesn7431uv.fsf@sykes.suse.de>
User-Agent: Gnus/5.090005 (Oort Gnus v0.05) Emacs/21.2.50 (ia64-suse-linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2002-03/txt/msg00190.txt.bz2

Michal Ludvig <mludvig@suse.cz> writes:

|> Daniel Jacobowitz wrote:
|> > Michal, are you OK with just the IP address?
|> 
|> Sure I am :-) Patch follows... Is it OK?
|> 
|> Index: ChangeLog
|> 	* remote-utils.c (remote_open): Print remote-side's
|> 	IP address when remote debugging over the network.
|> 
|> Index: remote-utils.c
|> ===================================================================
|> RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v
|> retrieving revision 1.8
|> diff -c -3 -p -r1.8 remote-utils.c
|> *** remote-utils.c      2002/02/14 06:21:22     1.8
|> --- remote-utils.c      2002/03/13 14:11:16
|> *************** static int remote_desc;
|> *** 47,53 ****
|>    void
|>    remote_open (char *name)
|>    {
|> !   int save_fcntl_flags;
|> 
|>      if (!strchr (name, ':'))
|>        {
|> --- 47,56 ----
|>    void
|>    remote_open (char *name)
|>    {
|> !   int save_fcntl_flags, via_network=0;;
|> !   char namebuf[100];
|> !
|> !   snprintf(namebuf, 100, "%s", name);

Why are you truncating the name to 100 characters?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."