Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa?] Add frame_align(); Was: ARM stack alignment on hand  called functions
Date: Thu, 28 Nov 2002 02:20:00 -0000	[thread overview]
Message-ID: <jer8d65732.fsf@sykes.suse.de> (raw)
In-Reply-To: <200211280926.gAS9QJE06150@pc960.cambridge.arm.com> (Richard Earnshaw's message of "Thu, 28 Nov 2002 09:26:19 +0000")

Richard Earnshaw <rearnsha@arm.com> writes:

|> > +/* Ensure that the ARM's stack pointer has the correct alignment for a
|> > +   new frame.  */
|> > +static CORE_ADDR
|> > +arm_frame_align (struct gdbarch *gdbarch, CORE_ADDR addr)
|> > +{
|> > +  return (addr & -16);
|> > +}
|> 
|> Yuck, two's complement assumption.

No, -16 is implicitly cast to bfd_vma, which is unsigned, and this
operation is completely defined independent of the representation of
signed integers.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2002-11-28 10:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200211270917.gAR9HNE29771@pc960.cambridge.arm.com>
2002-11-27 10:43 ` Andrew Cagney
2002-11-28  1:26   ` Richard Earnshaw
2002-11-28  2:20     ` Andreas Schwab [this message]
2002-11-28  2:41       ` Richard Earnshaw
2002-11-28  2:45         ` Andreas Schwab
2002-11-28  2:57           ` Richard Earnshaw
2002-11-28  5:52         ` Keith Walker
2002-11-28  7:34           ` Andrew Cagney
2002-11-28  7:19     ` Andrew Cagney
2002-11-28  8:33       ` Richard Earnshaw
2002-11-28  8:45         ` Andrew Cagney
2002-11-28  8:50           ` Richard Earnshaw
2002-11-28  9:00             ` Andrew Cagney
2003-01-29  5:19               ` Andrew Cagney
2003-01-29 14:50                 ` Kris Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jer8d65732.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox