From: Andrew Cagney <ac131313@redhat.com>
To: Richard.Earnshaw@arm.com
Cc: Kris Warkentin <kewarken@qnx.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa?] Add frame_align(); Was: ARM stack alignment on hand called functions
Date: Thu, 28 Nov 2002 07:19:00 -0000 [thread overview]
Message-ID: <3DE633E1.7060900@redhat.com> (raw)
In-Reply-To: <200211280926.gAS9QJE06150@pc960.cambridge.arm.com>
>> +/* Ensure that the ARM's stack pointer has the correct alignment for a
>> + new frame. */
>> +static CORE_ADDR
>> +arm_frame_align (struct gdbarch *gdbarch, CORE_ADDR addr)
>> +{
>> + return (addr & -16);
>> +}
>
>
> Yuck, two's complement assumption. I much prefer ~0xf in this case.
>
> But why so much. The maximum stack alignment you'll see on an ARM is 8
> bytes.
The function was lifted from the PPC code. And, hey, what's a few extra
bytes between friends? :-)
Does (addr & 0x7) look better?
Andrew
next prev parent reply other threads:[~2002-11-28 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200211270917.gAR9HNE29771@pc960.cambridge.arm.com>
2002-11-27 10:43 ` Andrew Cagney
2002-11-28 1:26 ` Richard Earnshaw
2002-11-28 2:20 ` Andreas Schwab
2002-11-28 2:41 ` Richard Earnshaw
2002-11-28 2:45 ` Andreas Schwab
2002-11-28 2:57 ` Richard Earnshaw
2002-11-28 5:52 ` Keith Walker
2002-11-28 7:34 ` Andrew Cagney
2002-11-28 7:19 ` Andrew Cagney [this message]
2002-11-28 8:33 ` Richard Earnshaw
2002-11-28 8:45 ` Andrew Cagney
2002-11-28 8:50 ` Richard Earnshaw
2002-11-28 9:00 ` Andrew Cagney
2003-01-29 5:19 ` Andrew Cagney
2003-01-29 14:50 ` Kris Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DE633E1.7060900@redhat.com \
--to=ac131313@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kewarken@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox