From: Andreas Schwab <schwab@suse.de>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] Replace DEPRECATED_STREQ
Date: Wed, 16 Jan 2008 09:59:00 -0000 [thread overview]
Message-ID: <jer6gi2irx.fsf@sykes.suse.de> (raw)
In-Reply-To: <478DD3EB.3020803@de.ibm.com> (Markus Deuling's message of "Wed\, 16 Jan 2008 10\:52\:43 +0100")
Markus Deuling <deuling@de.ibm.com> writes:
> diff -urpN src/gdb/coffread.c dev/gdb/coffread.c
> --- src/gdb/coffread.c 2008-01-01 23:53:09.000000000 +0100
> +++ dev/gdb/coffread.c 2008-01-16 09:48:28.000000000 +0100
> @@ -198,7 +198,7 @@ coff_locate_sections (bfd *abfd, asectio
>
> csi = (struct coff_symfile_info *) csip;
> name = bfd_get_section_name (abfd, sectp);
> - if (DEPRECATED_STREQ (name, ".text"))
> + if (!strcmp (name, ".text"))
I think you should generally use strcmp (...) == 0, since the return
value is not a boolean.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-01-16 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 9:55 Markus Deuling
2008-01-16 9:59 ` Andreas Schwab [this message]
2008-01-16 11:08 ` Markus Deuling
2008-01-16 11:15 ` Mark Kettenis
2008-01-16 11:23 ` Markus Deuling
2008-01-16 10:42 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer6gi2irx.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox