From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53358-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7400 invoked by alias); 16 Jan 2008 09:59:37 -0000
Received: (qmail 7390 invoked by uid 22791); 16 Jan 2008 09:59:37 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Jan 2008 09:59:17 +0000
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id DA57830397; 	Wed, 16 Jan 2008 10:59:14 +0100 (CET)
From: Andreas Schwab <schwab@suse.de>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, 	Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] Replace DEPRECATED_STREQ
References: <478DD3EB.3020803@de.ibm.com>
X-Yow: Yow!  I'm imagining a surfer van filled with soy sauce!
Date: Wed, 16 Jan 2008 09:59:00 -0000
In-Reply-To: <478DD3EB.3020803@de.ibm.com> (Markus Deuling's message of "Wed\, 	16 Jan 2008 10\:52\:43 +0100")
Message-ID: <jer6gi2irx.fsf@sykes.suse.de>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00390.txt.bz2

Markus Deuling <deuling@de.ibm.com> writes:

> diff -urpN src/gdb/coffread.c dev/gdb/coffread.c
> --- src/gdb/coffread.c	2008-01-01 23:53:09.000000000 +0100
> +++ dev/gdb/coffread.c	2008-01-16 09:48:28.000000000 +0100
> @@ -198,7 +198,7 @@ coff_locate_sections (bfd *abfd, asectio
>  
>    csi = (struct coff_symfile_info *) csip;
>    name = bfd_get_section_name (abfd, sectp);
> -  if (DEPRECATED_STREQ (name, ".text"))
> +  if (!strcmp (name, ".text"))

I think you should generally use strcmp (...) == 0, since the return
value is not a boolean.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."