Re: [RFA] Crossdebugging compilation fix for x86-64

[Andreas Schwab <schwab@suse.de>]

Daniel Jacobowitz <drow@mvista.com> writes:

|> On Mon, Mar 04, 2002 at 01:29:58PM +0100, Michal Ludvig wrote:
|> > Index: ChangeLog
|> > from Michal Ludvig <mludvig@suse.cz>
|> > 
|> >       * MAINTAINERS (x86-64): Target is not broken anymore.
|> >       * x86-64-tdep.h (sys/reg.h): Delete
|> >       (R15, R14, R13, R12, RBP, RBX, R11, R10, R9, R8, RAX, RCX, RDX,
|> >       RSI, RDI, ORIG, RIP, CS, EFLAGS, RSP, SS): Define. These can't be
|> >       included from sys/reg.h when compiling for cross-debuging.
|> 
|> These belong in a Linux-specific file.  Their order is not dependent on
|> anything in the x86-64 ABI, is it?

What puzzles me more is the fact that x86_64_regmap is defined (and not
just declared) in a header.  It is only used in x86-64-linux-nat.c, so it
should be moved there (and that file can use <sys/reg.h> freely).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."