From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13181-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9816 invoked by alias); 4 Mar 2002 18:03:22 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9740 invoked from network); 4 Mar 2002 18:03:15 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by sources.redhat.com with SMTP; 4 Mar 2002 18:03:15 -0000
Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136])
	by Cantor.suse.de (Postfix) with ESMTP id 86E931E57D
	for <gdb-patches@sources.redhat.com>; Mon,  4 Mar 2002 19:03:11 +0100 (MET)
X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f
To: Michal Ludvig <mludvig@suse.cz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Crossdebugging compilation fix for x86-64
References: <3C8368C6.90101@suse.cz> <20020304112017.A19528@nevyn.them.org>
X-Yow: PUNK ROCK!!  DISCO DUCK!!  BIRTH CONTROL!!
From: Andreas Schwab <schwab@suse.de>
Date: Mon, 04 Mar 2002 10:03:00 -0000
In-Reply-To: <20020304112017.A19528@nevyn.them.org> (Daniel Jacobowitz's
 message of "Mon, 4 Mar 2002 11:20:17 -0500")
Message-ID: <jepu2kgqhw.fsf@sykes.suse.de>
User-Agent: Gnus/5.090005 (Oort Gnus v0.05) Emacs/21.2.50 (ia64-suse-linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2002-03/txt/msg00033.txt.bz2

Daniel Jacobowitz <drow@mvista.com> writes:

|> On Mon, Mar 04, 2002 at 01:29:58PM +0100, Michal Ludvig wrote:
|> > Index: ChangeLog
|> > from Michal Ludvig <mludvig@suse.cz>
|> > 
|> >       * MAINTAINERS (x86-64): Target is not broken anymore.
|> >       * x86-64-tdep.h (sys/reg.h): Delete
|> >       (R15, R14, R13, R12, RBP, RBX, R11, R10, R9, R8, RAX, RCX, RDX,
|> >       RSI, RDI, ORIG, RIP, CS, EFLAGS, RSP, SS): Define. These can't be
|> >       included from sys/reg.h when compiling for cross-debuging.
|> 
|> These belong in a Linux-specific file.  Their order is not dependent on
|> anything in the x86-64 ABI, is it?

What puzzles me more is the fact that x86_64_regmap is defined (and not
just declared) in a header.  It is only used in x86-64-linux-nat.c, so it
should be moved there (and that file can use <sys/reg.h> freely).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."