Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* fix comment typo
@ 2006-09-07 12:30 Stephan Springl
  2006-09-07 12:35 ` Andreas Schwab
  2006-09-07 16:24 ` Joel Brobecker
  0 siblings, 2 replies; 3+ messages in thread
From: Stephan Springl @ 2006-09-07 12:30 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1212 bytes --]

Hi!

while digging into the fact that gdb 6.5 does not close .gdbinit and the 
child programs binary in the child process before execing, I found a typo.
BTW does anyone who is into gdb know how to close the possibly open init 
file without looking at the whole code?

Stephan

index 1bfb98b..a95984d 100644
Binary files a/gdb/.fork-child.c.swp and b/gdb/.fork-child.c.swp differ
index 8940151..44049dc 100644
--- a/gdb/fork-child.c
+++ b/gdb/fork-child.c
@@ -277,7 +277,7 @@ #endif
      (*pre_trace_fun) ();

    /* Create the child process.  Since the child process is going to
-     exec(3) shortlty afterwards, try to reduce the overhead by
+     exec(3) shortly afterwards, try to reduce the overhead by
       calling vfork(2).  However, if PRE_TRACE_FUN is non-null, it's
       likely that this optimization won't work since there's too much
       work to do between the vfork(2) and the exec(3).  This is known

--
Stephan Springl                           BFW Werner Völk GmbH
springl-gdb@bfw-online.de                 Energiemesstechnik & Service
+49 89 82917-452                          Drosselgasse 5
                                           82166 Gräfelfing/München

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: fix comment typo
  2006-09-07 12:30 fix comment typo Stephan Springl
@ 2006-09-07 12:35 ` Andreas Schwab
  2006-09-07 16:24 ` Joel Brobecker
  1 sibling, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2006-09-07 12:35 UTC (permalink / raw)
  To: Stephan Springl; +Cc: gdb-patches

Stephan Springl <springl-gdb@bfw-online.de> writes:

> BTW does anyone who is into gdb know how to close the possibly open init
> file without looking at the whole code?

Easiest probably by making the fds close on exec.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: fix comment typo
  2006-09-07 12:30 fix comment typo Stephan Springl
  2006-09-07 12:35 ` Andreas Schwab
@ 2006-09-07 16:24 ` Joel Brobecker
  1 sibling, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2006-09-07 16:24 UTC (permalink / raw)
  To: Stephan Springl; +Cc: gdb-patches


> while digging into the fact that gdb 6.5 does not close .gdbinit and the 
> child programs binary in the child process before execing, I found a typo.

Thanks Stephan, I committed your patch as obvious. For anything less
obvious we would need a copyright assignment in place, but this is
definitely fine.

2006-09-07  Joel Brobecker  <brobecker@adacore.com>

        From Stephan Springl  <springl-gdb@bfw-online.de>
        * fork-child.c (fork_inferior): Fix typo.

> index 8940151..44049dc 100644
> --- a/gdb/fork-child.c
> +++ b/gdb/fork-child.c
> @@ -277,7 +277,7 @@ #endif
>      (*pre_trace_fun) ();
> 
>    /* Create the child process.  Since the child process is going to
> -     exec(3) shortlty afterwards, try to reduce the overhead by
> +     exec(3) shortly afterwards, try to reduce the overhead by
>       calling vfork(2).  However, if PRE_TRACE_FUN is non-null, it's
>       likely that this optimization won't work since there's too much
>       work to do between the vfork(2) and the exec(3).  This is known


-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-09-07 16:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-07 12:30 fix comment typo Stephan Springl
2006-09-07 12:35 ` Andreas Schwab
2006-09-07 16:24 ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox