Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdbserver: Add support for qGetTLSAddr packet
Date: Mon, 06 Dec 2004 23:48:00 -0000	[thread overview]
Message-ID: <jemzwr3s7u.fsf@sykes.suse.de> (raw)
In-Reply-To: <20041206152002.551f8d46.kevinb@redhat.com> (Kevin Buettner's message of "Mon, 6 Dec 2004 15:20:02 -0700")

Kevin Buettner <kevinb@redhat.com> writes:

> Index: gdbserver/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v
> retrieving revision 1.27
> diff -u -p -r1.27 Makefile.in
> --- gdbserver/Makefile.in	16 Oct 2004 16:18:54 -0000	1.27
> +++ gdbserver/Makefile.in	6 Dec 2004 21:58:56 -0000
> @@ -246,6 +246,8 @@ proc-service.o: proc-service.c $(server_
>  regcache.o: regcache.c $(server_h) $(regdef_h)
>  remote-utils.o: remote-utils.c terminal.h $(server_h)
>  server.o: server.c $(server_h)
> +	$(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@

IMHO it is preferable to assign any substitution to a variable and use
that in any reference.  That makes it easier to override it for debugging
or whatever.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2004-12-06 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 22:37 Kevin Buettner
2004-12-06 23:48 ` Andreas Schwab [this message]
2005-02-25 15:52 ` Daniel Jacobowitz
2005-02-25 21:19   ` Kevin Buettner
2005-05-01 23:25     ` Daniel Jacobowitz
2005-05-05 20:05       ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jemzwr3s7u.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox