From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9409 invoked by alias); 6 Dec 2004 23:46:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9399 invoked from network); 6 Dec 2004 23:46:47 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 6 Dec 2004 23:46:47 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 8673411D78D0; Tue, 7 Dec 2004 00:46:46 +0100 (CET) To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] gdbserver: Add support for qGetTLSAddr packet References: <20041206152002.551f8d46.kevinb@redhat.com> From: Andreas Schwab X-Yow: Do you think the ``Monkees'' should get gas on odd or even days? Date: Mon, 06 Dec 2004 23:48:00 -0000 In-Reply-To: <20041206152002.551f8d46.kevinb@redhat.com> (Kevin Buettner's message of "Mon, 6 Dec 2004 15:20:02 -0700") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-12/txt/msg00182.txt.bz2 Kevin Buettner writes: > Index: gdbserver/Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v > retrieving revision 1.27 > diff -u -p -r1.27 Makefile.in > --- gdbserver/Makefile.in 16 Oct 2004 16:18:54 -0000 1.27 > +++ gdbserver/Makefile.in 6 Dec 2004 21:58:56 -0000 > @@ -246,6 +246,8 @@ proc-service.o: proc-service.c $(server_ > regcache.o: regcache.c $(server_h) $(regdef_h) > remote-utils.o: remote-utils.c terminal.h $(server_h) > server.o: server.c $(server_h) > + $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@ IMHO it is preferable to assign any substitution to a variable and use that in any reference. That makes it easier to override it for debugging or whatever. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."