[RFA/doco] Add missing parens around GDB prompt in example

[RFA/doco] Add missing parens around GDB prompt in example

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hello,

I noticed that one of the examples looked strange because the gdb prompt
was missing the opening and closing parenthesis. In section "Additions
to Ada", we have:

> [...] For example,
> 
>     gdb print <JMPBUF_SAVE>[0]

It should be

>     (gdb) print <JMPBUF_SAVE>[0]

Fixed thusly.

2008-12-14  Joel Brobecker  <brobecker@adacore.com>

        * gdb.texinfo (Additions to Ada): Add the missing opening and closing
        parenthesis for the gdb prompt in one of the examples.

OK to check in?

Thanks,
-- 
Joel

[-- Attachment #2: gdb-doc.diff --]
[-- Type: text/plain, Size: 423 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index a6fabe3..5901931 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -11517,7 +11517,7 @@ For the rare occasions when you actually have to look at them,
 enclose them in angle brackets to avoid the lower-case mapping. 
 For example,
 @smallexample
-@value{GDBP} print <JMPBUF_SAVE>[0]
+(@value{GDBP}) print <JMPBUF_SAVE>[0]
 @end smallexample
 
 @item

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Andreas Schwab]

Joel Brobecker <brobecker@adacore.com> writes:

> I noticed that one of the examples looked strange because the gdb prompt
> was missing the opening and closing parenthesis. In section "Additions
> to Ada", we have:
>
>> [...] For example,
>> 
>>     gdb print <JMPBUF_SAVE>[0]
>
> It should be
>
>>     (gdb) print <JMPBUF_SAVE>[0]
>
> Fixed thusly.

The other examples on the page don't have a prompt at all, perhaps they
should.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Joel Brobecker]

> The other examples on the page don't have a prompt at all, perhaps they
> should.

Indeed! I can send a patch. Eli?

-- 
Joel

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Eli Zaretskii]

> Date: Sun, 14 Dec 2008 22:02:08 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > The other examples on the page don't have a prompt at all, perhaps they
> > should.
> 
> Indeed! I can send a patch. Eli?

Please do.  Thanks.

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

OK, here is a new patch that adds all missing prompts in the Ada sections.

2008-12-15  Joel Brobecker  <brobecker@adacore.com>

        * gdb.texinfo (Omissions from Ada): Add missing GDB prompt in
        examples.
        (Additions to Ada): Likewise. Add the missing opening and closing
        parenthesis of the GDB prompt in one of the examples.

OK to commit?

Thank you,
-- 
Joel

[-- Attachment #2: doc-prompt.diff --]
[-- Type: text/plain, Size: 2415 bytes --]

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 29a55af..6ef124c 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -11334,12 +11334,12 @@ There is limited support for array and record aggregates.  They are
 permitted only on the right sides of assignments, as in these examples:
 
 @smallexample
-set An_Array := (1, 2, 3, 4, 5, 6)
-set An_Array := (1, others => 0)
-set An_Array := (0|4 => 1, 1..3 => 2, 5 => 6)
-set A_2D_Array := ((1, 2, 3), (4, 5, 6), (7, 8, 9))
-set A_Record := (1, "Peter", True);
-set A_Record := (Name => "Peter", Id => 1, Alive => True)
+(@value{GDBP}) set An_Array := (1, 2, 3, 4, 5, 6)
+(@value{GDBP}) set An_Array := (1, others => 0)
+(@value{GDBP}) set An_Array := (0|4 => 1, 1..3 => 2, 5 => 6)
+(@value{GDBP}) set A_2D_Array := ((1, 2, 3), (4, 5, 6), (7, 8, 9))
+(@value{GDBP}) set A_Record := (1, "Peter", True);
+(@value{GDBP}) set A_Record := (Name => "Peter", Id => 1, Alive => True)
 @end smallexample
 
 Changing a
@@ -11361,8 +11361,8 @@ you can assign a value with a different size of @code{Vals} with two
 assignments:
 
 @smallexample
-set A_Rec.Len := 4
-set A_Rec := (Id => 42, Vals => (1, 2, 3, 4))
+(@value{GDBP}) set A_Rec.Len := 4
+(@value{GDBP}) set A_Rec := (Id => 42, Vals => (1, 2, 3, 4))
 @end smallexample
 
 As this example also illustrates, @value{GDBN} is very loose about the usual
@@ -11448,8 +11448,8 @@ The assignment statement is allowed as an expression, returning
 its right-hand operand as its value.  Thus, you may enter
 
 @smallexample
-set x := y + 3
-print A(tmp := y + 1)
+(@value{GDBP}) set x := y + 3
+(@value{GDBP}) print A(tmp := y + 1)
 @end smallexample
 
 @item 
@@ -11459,8 +11459,8 @@ This allows, for example,
 complex conditional breaks:
 
 @smallexample
-break f
-condition 1 (report(i); k += 1; A(k) > 100)
+(@value{GDBP}) break f
+(@value{GDBP}) condition 1 (report(i); k += 1; A(k) > 100)
 @end smallexample
 
 @item 
@@ -11484,7 +11484,7 @@ The subtype used as a prefix for the attributes @t{'Pos}, @t{'Min}, and
 to write
 
 @smallexample
-print 'max(x, y)
+(@value{GDBP}) print 'max(x, y)
 @end smallexample
 
 @item
@@ -11517,7 +11517,7 @@ For the rare occasions when you actually have to look at them,
 enclose them in angle brackets to avoid the lower-case mapping. 
 For example,
 @smallexample
-@value{GDBP} print <JMPBUF_SAVE>[0]
+(@value{GDBP}) print <JMPBUF_SAVE>[0]
 @end smallexample
 
 @item

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Eli Zaretskii]

> Date: Mon, 15 Dec 2008 11:36:29 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: schwab@suse.de, gdb-patches@sourceware.org
> 
> OK, here is a new patch that adds all missing prompts in the Ada sections.
> 
> 2008-12-15  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb.texinfo (Omissions from Ada): Add missing GDB prompt in
>         examples.
>         (Additions to Ada): Likewise. Add the missing opening and closing
>         parenthesis of the GDB prompt in one of the examples.
> 
> OK to commit?

Yes, thanks.

Re: [RFA/doco] Add missing parens around GDB prompt in example

[Joel Brobecker]

> > 2008-12-15  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * gdb.texinfo (Omissions from Ada): Add missing GDB prompt in
> >         examples.
> >         (Additions to Ada): Likewise. Add the missing opening and closing
> >         parenthesis of the GDB prompt in one of the examples.
> > 
> > OK to commit?
> 
> Yes, thanks.

Thanks, Eli. Checked in.

-- 
Joel