From: Andreas Schwab <schwab@suse.de>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Don't error out when variable not available
Date: Wed, 05 Jan 2005 19:23:00 -0000 [thread overview]
Message-ID: <jed5wj1yes.fsf@sykes.suse.de> (raw)
In-Reply-To: <41DB169A.8040103@gnu.org> (Andrew Cagney's message of "Tue, 04 Jan 2005 17:20:10 -0500")
Andrew Cagney <cagney@gnu.org> writes:
> Adding more special case code, as was done with your other patch, isn't
> the way to go.
There is really no reason to call error in loclist_read_variable when we
can return VALUE_OPTIMIZED_OUT, like we already to in
dwarf2_evaluate_loc_desc. Fixing that problem is orthogonal to the
general problem of not catching errors. That print_frame_args needs to
check for VALUE_OPTIMIZED_OUT is only because it calls val_print directly
without going through value_print. It already has to take care of NULL
value even though value_print would handle that as well. Sooner or later
it would probably have been required to add this case anyway.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-01-05 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-02 22:13 Andreas Schwab
2005-01-02 22:57 ` Daniel Jacobowitz
2005-01-02 23:49 ` Andreas Schwab
2005-01-03 0:49 ` Daniel Jacobowitz
2005-01-03 13:41 ` Andreas Schwab
2005-01-04 22:20 ` Andrew Cagney
2005-01-05 19:23 ` Andreas Schwab [this message]
2005-02-28 20:53 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jed5wj1yes.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox