From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15758 invoked by alias); 5 Jan 2005 19:23:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15641 invoked from network); 5 Jan 2005 19:22:57 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 5 Jan 2005 19:22:57 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 5D33412DB205; Wed, 5 Jan 2005 20:22:54 +0100 (CET) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: Don't error out when variable not available References: <41DB169A.8040103@gnu.org> From: Andreas Schwab X-Yow: ..Everything is....FLIPPING AROUND!! Date: Wed, 05 Jan 2005 19:23:00 -0000 In-Reply-To: <41DB169A.8040103@gnu.org> (Andrew Cagney's message of "Tue, 04 Jan 2005 17:20:10 -0500") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2005-01/txt/msg00030.txt.bz2 Andrew Cagney writes: > Adding more special case code, as was done with your other patch, isn't > the way to go. There is really no reason to call error in loclist_read_variable when we can return VALUE_OPTIMIZED_OUT, like we already to in dwarf2_evaluate_loc_desc. Fixing that problem is orthogonal to the general problem of not catching errors. That print_frame_args needs to check for VALUE_OPTIMIZED_OUT is only because it calls val_print directly without going through value_print. It already has to take care of NULL value even though value_print would handle that as well. Sooner or later it would probably have been required to add this case anyway. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."