From: Andreas Schwab <schwab@suse.de>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [m68k] fix return value extraction
Date: Fri, 09 Jun 2006 10:13:00 -0000 [thread overview]
Message-ID: <je64ja3aer.fsf@sykes.suse.de> (raw)
In-Reply-To: <44844CBA.6030600@codesourcery.com> (Nathan Sidwell's message of "Mon, 05 Jun 2006 16:24:42 +0100")
Nathan Sidwell <nathan@codesourcery.com> writes:
> *************** m68k_push_dummy_call (struct gdbarch *gd
> *** 423,428 ****
> --- 496,504 ----
> gdb_byte buf[4];
> int i;
>
> + /* Align the stack down to 4 bytes. Needed for coldfire. */
> + sp &= ~3;
> +
> /* Push arguments in reverse order. */
> for (i = nargs - 1; i >= 0; i--)
> {
I think this should be done through gdbarch_frame_align.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-06-09 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 15:26 Nathan Sidwell
2006-06-05 16:51 ` Andreas Schwab
2006-06-06 10:18 ` Nathan Sidwell
2006-06-06 10:50 ` Andreas Schwab
2006-06-06 12:31 ` Daniel Jacobowitz
2006-06-17 12:54 ` Andreas Schwab
2006-06-09 10:13 ` Andreas Schwab [this message]
2006-06-09 10:15 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je64ja3aer.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox