From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16746 invoked by alias); 9 Jun 2006 10:13:02 -0000 Received: (qmail 16722 invoked by uid 22791); 9 Jun 2006 10:13:00 -0000 X-Spam-Check-By: sourceware.org Received: from cantor.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Jun 2006 10:12:36 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 21C7FEF03; Fri, 9 Jun 2006 12:12:33 +0200 (CEST) From: Andreas Schwab To: Nathan Sidwell Cc: gdb-patches@sourceware.org Subject: Re: [m68k] fix return value extraction References: <44844CBA.6030600@codesourcery.com> X-Yow: I'm not an Iranian!! I voted for Dianne Feinstein!! Date: Fri, 09 Jun 2006 10:13:00 -0000 In-Reply-To: <44844CBA.6030600@codesourcery.com> (Nathan Sidwell's message of "Mon, 05 Jun 2006 16:24:42 +0100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00087.txt.bz2 Nathan Sidwell writes: > *************** m68k_push_dummy_call (struct gdbarch *gd > *** 423,428 **** > --- 496,504 ---- > gdb_byte buf[4]; > int i; > > + /* Align the stack down to 4 bytes. Needed for coldfire. */ > + sp &= ~3; > + > /* Push arguments in reverse order. */ > for (i = nargs - 1; i >= 0; i--) > { I think this should be done through gdbarch_frame_align. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."