* Improvement to i386_analyze_frame_setup
@ 2003-10-06 21:23 Andreas Schwab
2003-10-06 21:53 ` Mark Kettenis
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2003-10-06 21:23 UTC (permalink / raw)
To: gdb-patches
This patch improves the i386 frame setup analyzer by recognizing one more
case that GCC might generate.
Andreas.
2003-10-06 Andreas Schwab <schwab@suse.de>
* i386-tdep.c (i386_analyze_frame_setup): Also handle xorl/subl
with %eax.
--- gdb/i386-tdep.c.~1.170.~ 2003-10-06 10:19:03.000000000 +0200
+++ gdb/i386-tdep.c 2003-10-06 23:21:29.000000000 +0200
@@ -499,12 +499,14 @@ i386_analyze_frame_setup (CORE_ADDR pc,
xorl %ebx, %ebx
xorl %ecx, %ecx
xorl %edx, %edx
+ xorl %eax, %eax
and the equivalent
subl %ebx, %ebx
subl %ecx, %ecx
subl %edx, %edx
+ subl %eax, %eax
Make sure we only skip these instructions if we later see the
`movl %esp, %ebp' that actually sets up the frame. */
@@ -516,6 +518,7 @@ i386_analyze_frame_setup (CORE_ADDR pc,
case 0xdb: /* %ebx */
case 0xc9: /* %ecx */
case 0xd2: /* %edx */
+ case 0xc0: /* %eax */
skip += 2;
break;
default:
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Improvement to i386_analyze_frame_setup
2003-10-06 21:23 Improvement to i386_analyze_frame_setup Andreas Schwab
@ 2003-10-06 21:53 ` Mark Kettenis
0 siblings, 0 replies; 2+ messages in thread
From: Mark Kettenis @ 2003-10-06 21:53 UTC (permalink / raw)
To: schwab; +Cc: gdb-patches
From: Andreas Schwab <schwab@suse.de>
Date: Mon, 06 Oct 2003 23:23:56 +0200
This patch improves the i386 frame setup analyzer by recognizing one more
case that GCC might generate.
Andreas.
2003-10-06 Andreas Schwab <schwab@suse.de>
* i386-tdep.c (i386_analyze_frame_setup): Also handle xorl/subl
with %eax.
Looks OK to me. Please check this in.
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-06 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-06 21:23 Improvement to i386_analyze_frame_setup Andreas Schwab
2003-10-06 21:53 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox