From: Andreas Schwab <schwab@suse.de>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Signed vs. unsigned adresses in solib-svr4
Date: Wed, 09 May 2007 18:38:00 -0000 [thread overview]
Message-ID: <je3b25allk.fsf@sykes.suse.de> (raw)
In-Reply-To: <200705091755.l49HtVnV032361@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Wed\, 9 May 2007 19\:55\:31 +0200 \(CEST\)")
"Ulrich Weigand" <uweigand@de.ibm.com> writes:
> Looks like this patch broke building mipsnbsd-tdep.c
> (mipsnbsd_ilp32_fetch_link_map_offsets,
> mipsnbsd_lp64_fetch_link_map_offsets).
Thanks, I have checked this in as obvious.
Andreas.
2007-05-09 Andreas Schwab <schwab@suse.de>
* mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Don't
set removed members.
(mipsnbsd_lp64_fetch_link_map_offsets): Likewise.
--- mipsnbsd-tdep.c 6 May 2007 14:29:15 -0000 1.24
+++ mipsnbsd-tdep.c 9 May 2007 18:22:18 -0000
@@ -336,15 +336,10 @@ mipsnbsd_ilp32_fetch_link_map_offsets (v
/* Everything we need is in the first 24 bytes. */
lmo.link_map_size = 24;
lmo.l_addr_offset = 4;
- lmo.l_addr_size = 4;
lmo.l_name_offset = 8;
- lmo.l_name_size = 4;
lmo.l_ld_offset = 12;
- lmo.l_ld_size = 4;
lmo.l_next_offset = 16;
- lmo.l_next_size = 4;
lmo.l_prev_offset = 20;
- lmo.l_prev_size = 4;
}
return lmp;
@@ -368,15 +363,10 @@ mipsnbsd_lp64_fetch_link_map_offsets (vo
/* Everything we need is in the first 40 bytes. */
lmo.link_map_size = 48;
lmo.l_addr_offset = 0;
- lmo.l_addr_size = 8;
lmo.l_name_offset = 16;
- lmo.l_name_size = 8;
lmo.l_ld_offset = 24;
- lmo.l_ld_size = 8;
lmo.l_next_offset = 32;
- lmo.l_next_size = 8;
lmo.l_prev_offset = 40;
- lmo.l_prev_size = 8;
}
return lmp;
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-05-09 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 19:16 Andreas Schwab
2007-03-27 19:21 ` Daniel Jacobowitz
2007-03-27 20:20 ` Andreas Schwab
2007-03-27 20:36 ` Daniel Jacobowitz
2007-03-29 11:38 ` Andreas Schwab
2007-03-29 17:56 ` Daniel Jacobowitz
2007-04-10 6:57 ` Kevin Buettner
2007-03-31 9:10 ` Mark Kettenis
2007-05-09 17:55 ` Ulrich Weigand
2007-05-09 18:38 ` Andreas Schwab [this message]
2007-05-09 19:46 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je3b25allk.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox