From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21104 invoked by alias); 9 May 2007 18:38:41 -0000 Received: (qmail 21094 invoked by uid 22791); 9 May 2007 18:38:40 -0000 X-Spam-Check-By: sourceware.org Received: from mail.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 May 2007 18:38:35 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id A3CF21225F; Wed, 9 May 2007 20:38:32 +0200 (CEST) From: Andreas Schwab To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org Subject: Re: Signed vs. unsigned adresses in solib-svr4 References: <200705091755.l49HtVnV032361@d12av02.megacenter.de.ibm.com> X-Yow: HAIR TONICS, please!! Date: Wed, 09 May 2007 18:38:00 -0000 In-Reply-To: <200705091755.l49HtVnV032361@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Wed\, 9 May 2007 19\:55\:31 +0200 \(CEST\)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00136.txt.bz2 "Ulrich Weigand" writes: > Looks like this patch broke building mipsnbsd-tdep.c > (mipsnbsd_ilp32_fetch_link_map_offsets, > mipsnbsd_lp64_fetch_link_map_offsets). Thanks, I have checked this in as obvious. Andreas. 2007-05-09 Andreas Schwab * mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Don't set removed members. (mipsnbsd_lp64_fetch_link_map_offsets): Likewise. --- mipsnbsd-tdep.c 6 May 2007 14:29:15 -0000 1.24 +++ mipsnbsd-tdep.c 9 May 2007 18:22:18 -0000 @@ -336,15 +336,10 @@ mipsnbsd_ilp32_fetch_link_map_offsets (v /* Everything we need is in the first 24 bytes. */ lmo.link_map_size = 24; lmo.l_addr_offset = 4; - lmo.l_addr_size = 4; lmo.l_name_offset = 8; - lmo.l_name_size = 4; lmo.l_ld_offset = 12; - lmo.l_ld_size = 4; lmo.l_next_offset = 16; - lmo.l_next_size = 4; lmo.l_prev_offset = 20; - lmo.l_prev_size = 4; } return lmp; @@ -368,15 +363,10 @@ mipsnbsd_lp64_fetch_link_map_offsets (vo /* Everything we need is in the first 40 bytes. */ lmo.link_map_size = 48; lmo.l_addr_offset = 0; - lmo.l_addr_size = 8; lmo.l_name_offset = 16; - lmo.l_name_size = 8; lmo.l_ld_offset = 24; - lmo.l_ld_size = 8; lmo.l_next_offset = 32; - lmo.l_next_size = 8; lmo.l_prev_offset = 40; - lmo.l_prev_size = 8; } return lmp; -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."