Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: New ARI warning Sat Aug 14 01:53:52 UTC 2010
Date: Sat, 14 Aug 2010 09:39:00 -0000	[thread overview]
Message-ID: <i45o7v$iek$1@dough.gmane.org> (raw)
In-Reply-To: <20100814015352.GA10686@sourceware.org>

GDB Administrator wrote:

> 814a815,817

>> gdb/mi/mi-main.c:1512: code: sprintf: Do not use sprintf, instead use xstrprintf
> gdb/mi/mi-main.c:1512:	  sprintf (p, ', read_result->data[i]);

This warning is bogus in this context. How do I silence it?

>> gdb/mi/mi-main.c:1490: gettext: _ markup: All messages should be marked up with _.
> gdb/mi/mi-main.c:1490:    error ("Unable to read memory.");
>> gdb/mi/mi-main.c:1582: gettext: _ markup: All messages should be marked up with _.
> gdb/mi/mi-main.c:1582:    error ("mi_cmd_data_write_memory: Usage: [-o COLUMN_OFFSET] ADDR FORMAT
> WORD-SIZE VALUE."); 821a825
>> gdb/mi/mi-main.c:1738: gettext: _ markup: All messages should be marked up with _.
> gdb/mi/mi-main.c:1738:    error ("the specified thread group does not exist");

Of above warnings, only first appears to be added by a recent patch of mine,
while others were there all the time. That said, have we ever decided if MI
should try to i18n its error messages? At least some of messages, like
"Unable to read memory" above, can probably be shown to user -- except it's
so generic as to be useless. Some messages, clearly, indicate frontend
bugs and showing them to users, or l10n-ing, makes no sense.

Comments?

- Volodya





  reply	other threads:[~2010-08-14  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14  1:54 GDB Administrator
2010-08-14  9:39 ` Vladimir Prus [this message]
2010-08-16  8:37   ` Pierre Muller
2010-08-16 14:45   ` Joel Brobecker
2010-08-16 15:14     ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='i45o7v$iek$1@dough.gmane.org' \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox