From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21731 invoked by alias); 14 Aug 2010 09:39:32 -0000 Received: (qmail 21706 invoked by uid 22791); 14 Aug 2010 09:39:31 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_05,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Aug 2010 09:39:25 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OkDD0-0003Nf-JD for gdb-patches@sources.redhat.com; Sat, 14 Aug 2010 11:39:22 +0200 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Aug 2010 11:39:22 +0200 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 14 Aug 2010 11:39:22 +0200 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: New ARI warning Sat Aug 14 01:53:52 UTC 2010 Followup-To: gmane.comp.gdb.patches Date: Sat, 14 Aug 2010 09:39:00 -0000 Message-ID: References: <20100814015352.GA10686@sourceware.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit User-Agent: KNode/4.3.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00206.txt.bz2 GDB Administrator wrote: > 814a815,817 >> gdb/mi/mi-main.c:1512: code: sprintf: Do not use sprintf, instead use xstrprintf > gdb/mi/mi-main.c:1512: sprintf (p, ', read_result->data[i]); This warning is bogus in this context. How do I silence it? >> gdb/mi/mi-main.c:1490: gettext: _ markup: All messages should be marked up with _. > gdb/mi/mi-main.c:1490: error ("Unable to read memory."); >> gdb/mi/mi-main.c:1582: gettext: _ markup: All messages should be marked up with _. > gdb/mi/mi-main.c:1582: error ("mi_cmd_data_write_memory: Usage: [-o COLUMN_OFFSET] ADDR FORMAT > WORD-SIZE VALUE."); 821a825 >> gdb/mi/mi-main.c:1738: gettext: _ markup: All messages should be marked up with _. > gdb/mi/mi-main.c:1738: error ("the specified thread group does not exist"); Of above warnings, only first appears to be added by a recent patch of mine, while others were there all the time. That said, have we ever decided if MI should try to i18n its error messages? At least some of messages, like "Unable to read memory" above, can probably be shown to user -- except it's so generic as to be useless. Some messages, clearly, indicate frontend bugs and showing them to users, or l10n-ing, makes no sense. Comments? - Volodya