From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdb.mi/*.exp, send_gdb vs. gdb_test
Date: Wed, 02 Jun 2010 08:49:00 -0000 [thread overview]
Message-ID: <hu55ul$c79$1@dough.gmane.org> (raw)
In-Reply-To: <4BFD54C5.4060409@vmware.com>
Michael Snyder wrote:
> Vladimir Prus wrote:
>> On Wednesday 26 May 2010 04:36:02 Michael Snyder wrote:
>>
>>> - send_gdb "-gdb-version\n"
>>> - gdb_expect {
>>> - -re "GNU gdb .*\r\n$mi_gdb_prompt$" \
>>> - { pass "acceptance of MI operations"
>>> - return 1}
>>> - -re ".*\r\n$mi_gdb_prompt$" \
>>> - { fail "acceptance of MI operations"
>>> - note "Skipping all other MI tests." }
>>> - -re "Undefined command.*$gdb_prompt $" \
>>> - { fail "acceptance of MI operations"
>>> - note "Skipping all other MI tests." }
>>> - -re ".*$gdb_prompt $" \
>>> - { fail "acceptance of MI operations"
>>> - note "Skipping all other MI tests." }
>>> - timeout { fail "acceptance of MI operations (timeout)"
>>> - note "Skipping all other MI tests." }
>>> + gdb_test_multiple "-gdb-version" "acceptance of MI operations" {
>>
>> You replace send_gdb with gdb_test_multiple, while changelog say you
>> replace with gdb_test.
>>
>>> + note "Skipping all other MI tests."
>>
>> This seem to be emitted unconditionally now? It was previously emitted
>> on timeout only. There are two such issues in -- mi-basics and mi2-basics.
>> Seems OK otherwise.
>
> It's not unconditional. The "pass" clause includes a return, so this
> note will only be emitted on failure.
OK, then this is not an issue.
- Volodya
next prev parent reply other threads:[~2010-06-02 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 1:55 Michael Snyder
2010-05-26 7:49 ` Vladimir Prus
2010-05-26 17:07 ` Michael Snyder
2010-06-02 8:49 ` Vladimir Prus [this message]
2010-08-26 15:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hu55ul$c79$1@dough.gmane.org' \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox