From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26819 invoked by alias); 2 Jun 2010 08:49:49 -0000 Received: (qmail 26810 invoked by uid 22791); 2 Jun 2010 08:49:48 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 08:49:39 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OJjdm-0007oR-Rk for gdb-patches@sources.redhat.com; Wed, 02 Jun 2010 10:49:34 +0200 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Jun 2010 10:49:34 +0200 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Jun 2010 10:49:34 +0200 To: gdb-patches@sources.redhat.com connect(): No such file or directory From: Vladimir Prus Subject: Re: [RFA] gdb.mi/*.exp, send_gdb vs. gdb_test Followup-To: gmane.comp.gdb.patches Date: Wed, 02 Jun 2010 08:49:00 -0000 Message-ID: References: <4BFC6CF2.1090103@vmware.com> <201005260844.17679.vladimir@codesourcery.com> <4BFD54C5.4060409@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit User-Agent: KNode/4.3.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00038.txt.bz2 Michael Snyder wrote: > Vladimir Prus wrote: >> On Wednesday 26 May 2010 04:36:02 Michael Snyder wrote: >> >>> - send_gdb "-gdb-version\n" >>> - gdb_expect { >>> - -re "GNU gdb .*\r\n$mi_gdb_prompt$" \ >>> - { pass "acceptance of MI operations" >>> - return 1} >>> - -re ".*\r\n$mi_gdb_prompt$" \ >>> - { fail "acceptance of MI operations" >>> - note "Skipping all other MI tests." } >>> - -re "Undefined command.*$gdb_prompt $" \ >>> - { fail "acceptance of MI operations" >>> - note "Skipping all other MI tests." } >>> - -re ".*$gdb_prompt $" \ >>> - { fail "acceptance of MI operations" >>> - note "Skipping all other MI tests." } >>> - timeout { fail "acceptance of MI operations (timeout)" >>> - note "Skipping all other MI tests." } >>> + gdb_test_multiple "-gdb-version" "acceptance of MI operations" { >> >> You replace send_gdb with gdb_test_multiple, while changelog say you >> replace with gdb_test. >> >>> + note "Skipping all other MI tests." >> >> This seem to be emitted unconditionally now? It was previously emitted >> on timeout only. There are two such issues in -- mi-basics and mi2-basics. >> Seems OK otherwise. > > It's not unconditional. The "pass" clause includes a return, so this > note will only be emitted on failure. OK, then this is not an issue. - Volodya