[patch] nto-tdep cleanup

[patch] nto-tdep cleanup

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hello,

Yet another. This removes unused declarations/functions from 
nto-tdep*.

Thanks,

-- 
Aleksandar Ristovski
QNX Software Systems

ChangeLog:
* nto-tdep.h (nto_generic_supply_gpregset)
(nto_generic_supply_fpregset, nto_generic_supply_altregset): 
Remove.
* nto-tdep.c (nto_generic_supply_gpregset)
(nto_generic_supply_fpregset, nto_generic_supply_altregset): 
Remove.

[-- Attachment #2: nto-tdep-removeunused-20090611.diff --]
[-- Type: text/x-patch, Size: 1843 bytes --]

Index: gdb/nto-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.h,v
retrieving revision 1.15
diff -u -p -r1.15 nto-tdep.h
--- gdb/nto-tdep.h	11 Jun 2009 19:29:00 -0000	1.15
+++ gdb/nto-tdep.h	11 Jun 2009 19:56:42 -0000
@@ -156,15 +156,6 @@ enum gdb_osabi nto_elf_osabi_sniffer (bf
 
 void nto_initialize_signals (void);
 
-void nto_generic_supply_gpregset (const struct regset *, struct regcache *,
-				  int, const void *, size_t);
-
-void nto_generic_supply_fpregset (const struct regset *, struct regcache *,
-				  int, const void *, size_t);
-
-void nto_generic_supply_altregset (const struct regset *, struct regcache *,
-				   int, const void *, size_t);
-
 /* Dummy function for initializing nto_target_ops on targets which do
    not define a particular regset.  */
 void nto_dummy_supply_regset (struct regcache *regcache, char *regs);
Index: gdb/nto-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.c,v
retrieving revision 1.33
diff -u -p -r1.33 nto-tdep.c
--- gdb/nto-tdep.c	11 Jun 2009 19:29:00 -0000	1.33
+++ gdb/nto-tdep.c	11 Jun 2009 19:56:42 -0000
@@ -328,27 +328,6 @@ nto_in_dynsym_resolve_code (CORE_ADDR pc
 }
 
 void
-nto_generic_supply_gpregset (const struct regset *regset,
-			     struct regcache *regcache, int regnum,
-			     const void *gregs, size_t len)
-{
-}
-
-void
-nto_generic_supply_fpregset (const struct regset *regset,
-			     struct regcache *regcache, int regnum,
-			     const void *fpregs, size_t len)
-{
-}
-
-void
-nto_generic_supply_altregset (const struct regset *regset,
-			      struct regcache *regcache, int regnum,
-			      const void *altregs, size_t len)
-{
-}
-
-void
 nto_dummy_supply_regset (struct regcache *regcache, char *regs)
 {
   /* Do nothing.  */

Re: [patch] nto-tdep cleanup

[Joel Brobecker]

> ChangeLog:
> * nto-tdep.h (nto_generic_supply_gpregset)
> (nto_generic_supply_fpregset, nto_generic_supply_altregset): Remove.
> * nto-tdep.c (nto_generic_supply_gpregset)
> (nto_generic_supply_fpregset, nto_generic_supply_altregset): Remove.

This is OK (I consider patches that remove unused routines as obvious,
especially if you have no plans to use them again in the future).

-- 
Joel

Re: [patch] nto-tdep cleanup

[Aleksandar Ristovski]

Joel Brobecker wrote:
>> ChangeLog:
>> * nto-tdep.h (nto_generic_supply_gpregset)
>> (nto_generic_supply_fpregset, nto_generic_supply_altregset): Remove.
>> * nto-tdep.c (nto_generic_supply_gpregset)
>> (nto_generic_supply_fpregset, nto_generic_supply_altregset): Remove.
> 
> This is OK (I consider patches that remove unused routines as obvious,
> especially if you have no plans to use them again in the future).
> 

Committed.

Thank you,

-- 
Aleksandar Ristovski
QNX Software Systems