* [review] Document and extend readline-bindable functions
@ 2019-11-09 18:57 Tom Tromey (Code Review)
2019-11-09 20:03 ` Eli Zaretskii
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-09 18:57 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/603
......................................................................
Document and extend readline-bindable functions
This adds readline-bindable function names to a few gdb functions that
already had key bindings. This lets users change the bindings.
This also removes the gdb-command function. Due to how this function
is implemented, it doesn't make sense to allow binding it.
Finally, this updates the documentation to reflect these changes.
gdb/ChangeLog
2019-11-09 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_initialize_readline): Add new bindable readline
functions.
gdb/doc/ChangeLog
2019-11-09 Tom Tromey <tom@tromey.com>
* gdb.texinfo (TUI Keys): Document readline function names.
Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
---
M gdb/ChangeLog
M gdb/doc/ChangeLog
M gdb/doc/gdb.texinfo
M gdb/tui/tui.c
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f5c8a76..dd90ebd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-09 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c (tui_initialize_readline): Add new bindable readline
+ functions.
+
2019-11-08 Tom Tromey <tromey@adacore.com>
* top.c (read_command_file): Update.
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 660d41d..c660a6b 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,5 +1,9 @@
2019-11-09 Tom Tromey <tom@tromey.com>
+ * gdb.texinfo (TUI Keys): Document readline function names.
+
+2019-11-09 Tom Tromey <tom@tromey.com>
+
* gdb.texinfo (Editing): Document operate-and-get-next.
2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 1af5674..a1856e8 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27621,6 +27621,9 @@
the TUI mode, control is given back to the curses windows.
The screen is then refreshed.
+This key binding uses the bindable Readline function
+@code{tui-switch-mode}.
+
@kindex C-x 1
@item C-x 1
Use a TUI layout with only one window. The layout will
@@ -27629,6 +27632,9 @@
Think of this key binding as the Emacs @kbd{C-x 1} binding.
+This key binding uses the bindable Readline function
+@code{tui-delete-other-windows}.
+
@kindex C-x 2
@item C-x 2
Use a TUI layout with at least two windows. When the current
@@ -27638,6 +27644,9 @@
Think of it as the Emacs @kbd{C-x 2} binding.
+This key binding uses the bindable Readline function
+@code{tui-change-windows}.
+
@kindex C-x o
@item C-x o
Change the active window. The TUI associates several key bindings
@@ -27646,10 +27655,16 @@
Think of it as the Emacs @kbd{C-x o} binding.
+This key binding uses the bindable Readline function
+@code{tui-other-window}.
+
@kindex C-x s
@item C-x s
Switch in and out of the TUI SingleKey mode that binds single
keys to @value{GDBN} commands (@pxref{TUI Single Key Mode}).
+
+This key binding uses the bindable Readline function
+@code{next-keymap}.
@end table
The following key bindings only work in the TUI mode:
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 1568351..3f5ab41 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -330,8 +330,10 @@
Keymap tui_ctlx_keymap;
rl_add_defun ("tui-switch-mode", tui_rl_switch_mode, -1);
- rl_add_defun ("gdb-command", tui_rl_command_key, -1);
rl_add_defun ("next-keymap", tui_rl_next_keymap, -1);
+ rl_add_defun ("tui-delete-other-windows", tui_rl_delete_other_windows, -1);
+ rl_add_defun ("tui-change-windows", tui_rl_change_windows, -1);
+ rl_add_defun ("tui-other-window", tui_rl_other_window, -1);
tui_keymap = rl_make_bare_keymap ();
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
Gerrit-Change-Number: 603
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [review] Document and extend readline-bindable functions
2019-11-09 18:57 [review] Document and extend readline-bindable functions Tom Tromey (Code Review)
@ 2019-11-09 20:03 ` Eli Zaretskii
2019-11-11 23:57 ` Tom Tromey (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-11-09 20:03 UTC (permalink / raw)
To: tromey, gdb-patches
> Date: Sat, 9 Nov 2019 13:57:06 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
>
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/603
> ......................................................................
>
> Document and extend readline-bindable functions
>
> This adds readline-bindable function names to a few gdb functions that
> already had key bindings. This lets users change the bindings.
>
> This also removes the gdb-command function. Due to how this function
> is implemented, it doesn't make sense to allow binding it.
>
> Finally, this updates the documentation to reflect these changes.
>
> gdb/ChangeLog
> 2019-11-09 Tom Tromey <tom@tromey.com>
>
> * tui/tui.c (tui_initialize_readline): Add new bindable readline
> functions.
>
> gdb/doc/ChangeLog
> 2019-11-09 Tom Tromey <tom@tromey.com>
>
> * gdb.texinfo (TUI Keys): Document readline function names.
OK for the documentation part, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Document and extend readline-bindable functions
2019-11-09 18:57 [review] Document and extend readline-bindable functions Tom Tromey (Code Review)
2019-11-09 20:03 ` Eli Zaretskii
@ 2019-11-11 23:57 ` Tom Tromey (Code Review)
2019-11-12 0:01 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 0:01 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-11 23:57 UTC (permalink / raw)
To: gdb-patches
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/603
......................................................................
Patch Set 1:
I'm going to check these two in.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
Gerrit-Change-Number: 603
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 11 Nov 2019 23:57:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Document and extend readline-bindable functions
2019-11-09 18:57 [review] Document and extend readline-bindable functions Tom Tromey (Code Review)
2019-11-09 20:03 ` Eli Zaretskii
2019-11-11 23:57 ` Tom Tromey (Code Review)
@ 2019-11-12 0:01 ` Sourceware to Gerrit sync (Code Review)
2019-11-12 0:01 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-12 0:01 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/603
......................................................................
Document and extend readline-bindable functions
This adds readline-bindable function names to a few gdb functions that
already had key bindings. This lets users change the bindings.
This also removes the gdb-command function. Due to how this function
is implemented, it doesn't make sense to allow binding it.
Finally, this updates the documentation to reflect these changes.
gdb/ChangeLog
2019-11-11 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_initialize_readline): Add new bindable readline
functions.
gdb/doc/ChangeLog
2019-11-11 Tom Tromey <tom@tromey.com>
* gdb.texinfo (TUI Keys): Document readline function names.
Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
---
M gdb/ChangeLog
M gdb/doc/ChangeLog
M gdb/doc/gdb.texinfo
M gdb/tui/tui.c
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index edd3e90..e8104f3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-11 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c (tui_initialize_readline): Add new bindable readline
+ functions.
+
2019-11-11 Christian Biesinger <cbiesinger@google.com>
* nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 3c77d4f..0da4c9d 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,5 +1,9 @@
2019-11-11 Tom Tromey <tom@tromey.com>
+ * gdb.texinfo (TUI Keys): Document readline function names.
+
+2019-11-11 Tom Tromey <tom@tromey.com>
+
* gdb.texinfo (Editing): Document operate-and-get-next.
2019-11-11 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 05accca..398167f 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27621,6 +27621,9 @@
the TUI mode, control is given back to the curses windows.
The screen is then refreshed.
+This key binding uses the bindable Readline function
+@code{tui-switch-mode}.
+
@kindex C-x 1
@item C-x 1
Use a TUI layout with only one window. The layout will
@@ -27629,6 +27632,9 @@
Think of this key binding as the Emacs @kbd{C-x 1} binding.
+This key binding uses the bindable Readline function
+@code{tui-delete-other-windows}.
+
@kindex C-x 2
@item C-x 2
Use a TUI layout with at least two windows. When the current
@@ -27638,6 +27644,9 @@
Think of it as the Emacs @kbd{C-x 2} binding.
+This key binding uses the bindable Readline function
+@code{tui-change-windows}.
+
@kindex C-x o
@item C-x o
Change the active window. The TUI associates several key bindings
@@ -27646,10 +27655,16 @@
Think of it as the Emacs @kbd{C-x o} binding.
+This key binding uses the bindable Readline function
+@code{tui-other-window}.
+
@kindex C-x s
@item C-x s
Switch in and out of the TUI SingleKey mode that binds single
keys to @value{GDBN} commands (@pxref{TUI Single Key Mode}).
+
+This key binding uses the bindable Readline function
+@code{next-keymap}.
@end table
The following key bindings only work in the TUI mode:
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 1568351..3f5ab41 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -330,8 +330,10 @@
Keymap tui_ctlx_keymap;
rl_add_defun ("tui-switch-mode", tui_rl_switch_mode, -1);
- rl_add_defun ("gdb-command", tui_rl_command_key, -1);
rl_add_defun ("next-keymap", tui_rl_next_keymap, -1);
+ rl_add_defun ("tui-delete-other-windows", tui_rl_delete_other_windows, -1);
+ rl_add_defun ("tui-change-windows", tui_rl_change_windows, -1);
+ rl_add_defun ("tui-other-window", tui_rl_other_window, -1);
tui_keymap = rl_make_bare_keymap ();
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
Gerrit-Change-Number: 603
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Document and extend readline-bindable functions
2019-11-09 18:57 [review] Document and extend readline-bindable functions Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-11-12 0:01 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-12 0:01 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-12 0:01 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/603
......................................................................
Document and extend readline-bindable functions
This adds readline-bindable function names to a few gdb functions that
already had key bindings. This lets users change the bindings.
This also removes the gdb-command function. Due to how this function
is implemented, it doesn't make sense to allow binding it.
Finally, this updates the documentation to reflect these changes.
gdb/ChangeLog
2019-11-11 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_initialize_readline): Add new bindable readline
functions.
gdb/doc/ChangeLog
2019-11-11 Tom Tromey <tom@tromey.com>
* gdb.texinfo (TUI Keys): Document readline function names.
Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
---
M gdb/ChangeLog
M gdb/doc/ChangeLog
M gdb/doc/gdb.texinfo
M gdb/tui/tui.c
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index edd3e90..e8104f3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-11 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.c (tui_initialize_readline): Add new bindable readline
+ functions.
+
2019-11-11 Christian Biesinger <cbiesinger@google.com>
* nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 3c77d4f..0da4c9d 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,5 +1,9 @@
2019-11-11 Tom Tromey <tom@tromey.com>
+ * gdb.texinfo (TUI Keys): Document readline function names.
+
+2019-11-11 Tom Tromey <tom@tromey.com>
+
* gdb.texinfo (Editing): Document operate-and-get-next.
2019-11-11 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 05accca..398167f 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27621,6 +27621,9 @@
the TUI mode, control is given back to the curses windows.
The screen is then refreshed.
+This key binding uses the bindable Readline function
+@code{tui-switch-mode}.
+
@kindex C-x 1
@item C-x 1
Use a TUI layout with only one window. The layout will
@@ -27629,6 +27632,9 @@
Think of this key binding as the Emacs @kbd{C-x 1} binding.
+This key binding uses the bindable Readline function
+@code{tui-delete-other-windows}.
+
@kindex C-x 2
@item C-x 2
Use a TUI layout with at least two windows. When the current
@@ -27638,6 +27644,9 @@
Think of it as the Emacs @kbd{C-x 2} binding.
+This key binding uses the bindable Readline function
+@code{tui-change-windows}.
+
@kindex C-x o
@item C-x o
Change the active window. The TUI associates several key bindings
@@ -27646,10 +27655,16 @@
Think of it as the Emacs @kbd{C-x o} binding.
+This key binding uses the bindable Readline function
+@code{tui-other-window}.
+
@kindex C-x s
@item C-x s
Switch in and out of the TUI SingleKey mode that binds single
keys to @value{GDBN} commands (@pxref{TUI Single Key Mode}).
+
+This key binding uses the bindable Readline function
+@code{next-keymap}.
@end table
The following key bindings only work in the TUI mode:
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 1568351..3f5ab41 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -330,8 +330,10 @@
Keymap tui_ctlx_keymap;
rl_add_defun ("tui-switch-mode", tui_rl_switch_mode, -1);
- rl_add_defun ("gdb-command", tui_rl_command_key, -1);
rl_add_defun ("next-keymap", tui_rl_next_keymap, -1);
+ rl_add_defun ("tui-delete-other-windows", tui_rl_delete_other_windows, -1);
+ rl_add_defun ("tui-change-windows", tui_rl_change_windows, -1);
+ rl_add_defun ("tui-other-window", tui_rl_other_window, -1);
tui_keymap = rl_make_bare_keymap ();
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2233779b7aefe372f19bd03c8f325733c3385e72
Gerrit-Change-Number: 603
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-12 0:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 18:57 [review] Document and extend readline-bindable functions Tom Tromey (Code Review)
2019-11-09 20:03 ` Eli Zaretskii
2019-11-11 23:57 ` Tom Tromey (Code Review)
2019-11-12 0:01 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 0:01 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox