From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sources.redhat.com
Subject: Re: attach& support, and attach "async + sync_execution" support.
Date: Sat, 15 Mar 2008 16:22:00 -0000 [thread overview]
Message-ID: <frgt2l$hto$1@ger.gmane.org> (raw)
In-Reply-To: <20080314191821.GG31663@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Fri, Mar 14, 2008 at 08:05:39AM +0000, Pedro Alves wrote:
>> 2008-03-14 Pedro Alves <pedro@codesourcery.com>
>>
>> * infcmd.c (attach_command_async_continuation): New.
>> (attach_command): Support background async execution, and async
>> execution in synchronous mode.
>
> Could you do some refactoring on this, please? It duplicates code
> from attach_command.
Right.
> When I fixed up step last year I moved the
> common code into its own function. Makes it much easier to see
> the differences between async and sync operation. And for instance
> it lets me see that you're calling deprecated_attach_hook twice
> in async mode :-)
In fact, it's quite possible to always install continuation, and
then immediately run it in a sync mode. I have a patch doing the same
for finish; guess I better post it now ;-)
- Volodya
next prev parent reply other threads:[~2008-03-15 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 8:05 Pedro Alves
2008-03-14 19:18 ` Daniel Jacobowitz
2008-03-15 16:22 ` Vladimir Prus [this message]
2008-03-17 15:48 ` Pedro Alves
2008-03-17 16:18 ` Daniel Jacobowitz
2008-03-17 17:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='frgt2l$hto$1@ger.gmane.org' \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox