From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10468 invoked by alias); 15 Mar 2008 16:22:18 -0000 Received: (qmail 10460 invoked by uid 22791); 15 Mar 2008 16:22:18 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Mar 2008 16:21:58 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JaZ8n-0002cP-Ml for gdb-patches@sources.redhat.com; Sat, 15 Mar 2008 16:21:49 +0000 Received: from 78.158.192.230 ([78.158.192.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 15 Mar 2008 16:21:49 +0000 Received: from ghost by 78.158.192.230 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 15 Mar 2008 16:21:49 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: attach& support, and attach "async + sync_execution" support. Date: Sat, 15 Mar 2008 16:22:00 -0000 Message-ID: References: <200803140805.40116.pedro@codesourcery.com> <20080314191821.GG31663@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00216.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Mar 14, 2008 at 08:05:39AM +0000, Pedro Alves wrote: >> 2008-03-14 Pedro Alves >> >> * infcmd.c (attach_command_async_continuation): New. >> (attach_command): Support background async execution, and async >> execution in synchronous mode. > > Could you do some refactoring on this, please? It duplicates code > from attach_command. Right. > When I fixed up step last year I moved the > common code into its own function. Makes it much easier to see > the differences between async and sync operation. And for instance > it lets me see that you're calling deprecated_attach_hook twice > in async mode :-) In fact, it's quite possible to always install continuation, and then immediately run it in a sync mode. I have a patch doing the same for finish; guess I better post it now ;-) - Volodya